# git rev-parse -q --verify e3d773ddb5a1140780a15703b3e0e2618274cce9^{commit} e3d773ddb5a1140780a15703b3e0e2618274cce9 already have revision, skipping fetch # git checkout -q -f -B kisskb e3d773ddb5a1140780a15703b3e0e2618274cce9 # git clean -qxdf # < git log -1 # commit e3d773ddb5a1140780a15703b3e0e2618274cce9 # Author: Jordan Niethe # Date: Thu Feb 25 14:19:46 2021 +1100 # # powerpc/sstep: Fix VSX instruction emulation # # Commit af99da74333b ("powerpc/sstep: Support VSX vector paired storage # access instructions") added loading and storing 32 word long data into # adjacent VSRs. However the calculation used to determine if two VSRs # needed to be loaded/stored inadvertently prevented the load/storing # taking place for instructions with a data length less than 16 words. # # This causes the emulation to not function correctly, which can be seen # by the alignment_handler selftest: # # $ ./alignment_handler # [snip] # test: test_alignment_handler_vsx_207 # tags: git_version:powerpc-5.12-1-0-g82d2c16b350f # VSX: 2.07B # Doing lxsspx: PASSED # Doing lxsiwax: FAILED: Wrong Data # Doing lxsiwzx: PASSED # Doing stxsspx: PASSED # Doing stxsiwx: PASSED # failure: test_alignment_handler_vsx_207 # test: test_alignment_handler_vsx_300 # tags: git_version:powerpc-5.12-1-0-g82d2c16b350f # VSX: 3.00B # Doing lxsd: PASSED # Doing lxsibzx: PASSED # Doing lxsihzx: PASSED # Doing lxssp: FAILED: Wrong Data # Doing lxv: PASSED # Doing lxvb16x: PASSED # Doing lxvh8x: PASSED # Doing lxvx: PASSED # Doing lxvwsx: FAILED: Wrong Data # Doing lxvl: PASSED # Doing lxvll: PASSED # Doing stxsd: PASSED # Doing stxsibx: PASSED # Doing stxsihx: PASSED # Doing stxssp: PASSED # Doing stxv: PASSED # Doing stxvb16x: PASSED # Doing stxvh8x: PASSED # Doing stxvx: PASSED # Doing stxvl: PASSED # Doing stxvll: PASSED # failure: test_alignment_handler_vsx_300 # [snip] # # Fix this by making sure all VSX instruction emulation correctly # load/store from the VSRs. # # Fixes: af99da74333b ("powerpc/sstep: Support VSX vector paired storage access instructions") # Signed-off-by: Jordan Niethe # Reviewed-by: Ravi Bangoria # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210225031946.1458206-1-jniethe5@gmail.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 e3d773ddb5a1140780a15703b3e0e2618274cce9 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc86xx_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:135.22-137.4: Warning (pci_bridge): /pcie@f1008000: missing ranges for PCI bridge (or not a bridge) also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:92.7-117.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:102.9-116.4: Warning (pci_bridge): /pcie@f1008000/pcie@0: missing ranges for PCI bridge (or not a bridge) /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:139.22-141.4: Warning (pci_bridge): /pcie@f1009000: missing ranges for PCI bridge (or not a bridge) also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:119.7-144.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:129.9-143.4: Warning (pci_bridge): /pcie@f1009000/pcie@0: missing ranges for PCI bridge (or not a bridge) arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:30.11-32.6: Warning (i2c_bus_reg): /soc@f1000000/i2c@3000/rtc@68: missing or empty reg property INFO: Uncompressed kernel (size 0xca6318) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:43:11 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5677965 Bytes = 5544.89 KiB = 5.41 MiB Load Address: 00000000 Entry Point: 00000000 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc86xx_defconfig_powerpc-gcc5 # Build took: 0:02:18.336399