# git rev-parse -q --verify e3d773ddb5a1140780a15703b3e0e2618274cce9^{commit} e3d773ddb5a1140780a15703b3e0e2618274cce9 already have revision, skipping fetch # git checkout -q -f -B kisskb e3d773ddb5a1140780a15703b3e0e2618274cce9 # git clean -qxdf # < git log -1 # commit e3d773ddb5a1140780a15703b3e0e2618274cce9 # Author: Jordan Niethe # Date: Thu Feb 25 14:19:46 2021 +1100 # # powerpc/sstep: Fix VSX instruction emulation # # Commit af99da74333b ("powerpc/sstep: Support VSX vector paired storage # access instructions") added loading and storing 32 word long data into # adjacent VSRs. However the calculation used to determine if two VSRs # needed to be loaded/stored inadvertently prevented the load/storing # taking place for instructions with a data length less than 16 words. # # This causes the emulation to not function correctly, which can be seen # by the alignment_handler selftest: # # $ ./alignment_handler # [snip] # test: test_alignment_handler_vsx_207 # tags: git_version:powerpc-5.12-1-0-g82d2c16b350f # VSX: 2.07B # Doing lxsspx: PASSED # Doing lxsiwax: FAILED: Wrong Data # Doing lxsiwzx: PASSED # Doing stxsspx: PASSED # Doing stxsiwx: PASSED # failure: test_alignment_handler_vsx_207 # test: test_alignment_handler_vsx_300 # tags: git_version:powerpc-5.12-1-0-g82d2c16b350f # VSX: 3.00B # Doing lxsd: PASSED # Doing lxsibzx: PASSED # Doing lxsihzx: PASSED # Doing lxssp: FAILED: Wrong Data # Doing lxv: PASSED # Doing lxvb16x: PASSED # Doing lxvh8x: PASSED # Doing lxvx: PASSED # Doing lxvwsx: FAILED: Wrong Data # Doing lxvl: PASSED # Doing lxvll: PASSED # Doing stxsd: PASSED # Doing stxsibx: PASSED # Doing stxsihx: PASSED # Doing stxssp: PASSED # Doing stxv: PASSED # Doing stxvb16x: PASSED # Doing stxvh8x: PASSED # Doing stxvx: PASSED # Doing stxvl: PASSED # Doing stxvll: PASSED # failure: test_alignment_handler_vsx_300 # [snip] # # Fix this by making sure all VSX instruction emulation correctly # load/store from the VSRs. # # Fixes: af99da74333b ("powerpc/sstep: Support VSX vector paired storage access instructions") # Signed-off-by: Jordan Niethe # Reviewed-by: Ravi Bangoria # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210225031946.1458206-1-jniethe5@gmail.com # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 e3d773ddb5a1140780a15703b3e0e2618274cce9 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- powernv_defconfig # Added to kconfig CONFIG_NUMA=n # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/net/phy/phy_device.c:293:12: warning: 'mdio_bus_phy_resume' defined but not used [-Wunused-function] 293 | static int mdio_bus_phy_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/phy_device.c:273:12: warning: 'mdio_bus_phy_suspend' defined but not used [-Wunused-function] 273 | static int mdio_bus_phy_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc9 # Build took: 0:04:19.755940