# git rev-parse -q --verify 19d767f0429ab26cb3de6c1f7a805a973c5dbd26^{commit} 19d767f0429ab26cb3de6c1f7a805a973c5dbd26 already have revision, skipping fetch # git checkout -q -f -B kisskb 19d767f0429ab26cb3de6c1f7a805a973c5dbd26 # git clean -qxdf # < git log -1 # commit 19d767f0429ab26cb3de6c1f7a805a973c5dbd26 # Author: Michael Ellerman # Date: Mon Mar 1 14:32:14 2021 +1100 # # KVM: PPC: Book3S HV: Convert tbacct/stoltb_lock to raw spinlocks # # With CONFIG_PROVE_RAW_LOCK_NESTING=y we see lockdep splats when # running KVM: # # ============================= # [ BUG: Invalid wait context ] # 5.11.0-11811-gb49a419bbf28 #1 Not tainted # ----------------------------- # qemu-system-ppc/14068 is trying to lock: # c000000134282100 (&vcpu->arch.tbacct_lock){....}-{3:3}, at: kvmppc_core_vcpu_put_hv+0x44/0xd0 [kvm_hv] # other info that might help us debug this: # context-{5:5} # 2 locks held by qemu-system-ppc/14068: # #0: c0000001342800c8 (&vcpu->mutex){+.+.}-{4:4}, at: kvm_vcpu_ioctl+0xdc/0x8c0 [kvm] # #1: c000001e612cfa98 (&rq->lock){-.-.}-{2:2}, at: __schedule+0x1a4/0xdd0 # stack backtrace: # CPU: 10 PID: 14068 Comm: qemu-system-ppc Not tainted 5.11.0-11811-gb49a419bbf28 #1 # Call Trace: # dump_stack+0xec/0x144 (unreliable) # __lock_acquire+0xab0/0x2e70 # lock_acquire+0x128/0x600 # _raw_spin_lock_irqsave+0x6c/0xc0 # kvmppc_core_vcpu_put_hv+0x44/0xd0 [kvm_hv] # kvmppc_core_vcpu_put+0x34/0x50 [kvm] # kvm_arch_vcpu_put+0x20/0x40 [kvm] # kvm_sched_out+0x44/0x80 [kvm] # __schedule+0x684/0xdd0 # preempt_schedule_common+0x30/0x60 # __cond_resched+0x60/0x80 # kvmhv_run_single_vcpu+0xe2c/0x1220 [kvm_hv] # kvmppc_vcpu_run_hv+0x984/0xcd0 [kvm_hv] # kvmppc_vcpu_run+0x34/0x48 [kvm] # kvm_arch_vcpu_ioctl_run+0x340/0x450 [kvm] # kvm_vcpu_ioctl+0x2ac/0x8c0 [kvm] # sys_ioctl+0x300/0x1050 # system_call_exception+0x160/0x230 # system_call_common+0xec/0x278 # # Which is complaining that we're taking a regular # spinlock (tbacct_lock) while holding a raw spinlock (rq->lock). # # To fix it, convert tbacct_lock to a raw spinlock. # # We see a similar splat for stoltb_lock, the analysis & fix is the # same. # # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 19d767f0429ab26cb3de6c1f7a805a973c5dbd26 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4192:warning: override: reassigning to symbol PPC_E500MC .config:4193:warning: override: reassigning to symbol VIRTUALIZATION # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/net/phy/phy_device.c:293:12: warning: 'mdio_bus_phy_resume' defined but not used [-Wunused-function] 293 | static int mdio_bus_phy_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/phy_device.c:273:12: warning: 'mdio_bus_phy_suspend' defined but not used [-Wunused-function] 273 | static int mdio_bus_phy_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/kernel.h:10, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf4abd8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) INFO: Uncompressed kernel (size 0xf3a4ac) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1000000) Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086195 Bytes = 6920.11 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 0100031c Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7087072 Bytes = 6920.97 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086989 Bytes = 6920.89 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086127 Bytes = 6920.05 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 0100031c Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086604 Bytes = 6920.51 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 0100031c Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7087170 Bytes = 6921.06 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086269 Bytes = 6920.18 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086125 Bytes = 6920.04 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 0100031c Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086681 Bytes = 6920.59 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086538 Bytes = 6920.45 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086531 Bytes = 6920.44 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086134 Bytes = 6920.05 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086573 Bytes = 6920.48 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 0100031c Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7052050 Bytes = 6886.77 KiB = 6.73 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086365 Bytes = 6920.28 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Image Name: Linux-5.12.0-rc1-g19d767f0429a Created: Tue Mar 2 04:09:01 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7086096 Bytes = 6920.02 KiB = 6.76 MiB Load Address: 01000000 Entry Point: 010002cc Completed OK # rm -rf /kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 # Build took: 0:01:48.701209