# git rev-parse -q --verify 274cb1ca2e7ce02cab56f5f4c61a74aeb566f931^{commit} 274cb1ca2e7ce02cab56f5f4c61a74aeb566f931 already have revision, skipping fetch # git checkout -q -f -B kisskb 274cb1ca2e7ce02cab56f5f4c61a74aeb566f931 # git clean -qxdf # < git log -1 # commit 274cb1ca2e7ce02cab56f5f4c61a74aeb566f931 # Author: Nathan Lynch # Date: Mon Mar 15 03:00:45 2021 -0500 # # powerpc/pseries/mobility: handle premature return from H_JOIN # # The pseries join/suspend sequence in its current form was written with # the assumption that it was the only user of H_PROD and that it needn't # handle spurious successful returns from H_JOIN. That's wrong; # powerpc's paravirt spinlock code uses H_PROD, and CPUs entering # do_join() can be woken prematurely from H_JOIN with a status of # H_SUCCESS as a result. This causes all CPUs to exit the sequence # early, preventing suspend from occurring at all. # # Add a 'done' boolean flag to the pseries_suspend_info struct, and have # the waking thread set it before waking the other threads. Threads # which receive H_SUCCESS from H_JOIN retry if the 'done' flag is still # unset. # # Fixes: 9327dc0aeef3 ("powerpc/pseries/mobility: use stop_machine for join/suspend") # Signed-off-by: Nathan Lynch # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210315080045.460331-3-nathanl@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 274cb1ca2e7ce02cab56f5f4c61a74aeb566f931 # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+STRICT_RWX_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- powernv_defconfig # Added to kconfig CONFIG_RELOCATABLE=n # Added to kconfig CONFIG_STRICT_KERNEL_RWX=y # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+STRICT_RWX_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+STRICT_RWX_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4053:warning: override: reassigning to symbol RELOCATABLE # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+STRICT_RWX_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/net/phy/phy_device.c:293:12: warning: 'mdio_bus_phy_resume' defined but not used [-Wunused-function] 293 | static int mdio_bus_phy_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/phy_device.c:273:12: warning: 'mdio_bus_phy_suspend' defined but not used [-Wunused-function] 273 | static int mdio_bus_phy_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-fixes_powernv_defconfig+STRICT_RWX_powerpc-gcc9 # Build took: 0:03:47.907603