# git rev-parse -q --verify 07a361072378fb3ae116db86244372dbd68f9ea3^{commit} 07a361072378fb3ae116db86244372dbd68f9ea3 already have revision, skipping fetch # git checkout -q -f -B kisskb 07a361072378fb3ae116db86244372dbd68f9ea3 # git clean -qxdf # < git log -1 # commit 07a361072378fb3ae116db86244372dbd68f9ea3 # Author: Daniel Henrique Barboza # Date: Tue Mar 23 17:50:56 2021 -0300 # # powerpc/pseries/hotplug-cpu: Show 'last online CPU' error in dlpar_cpu_offline() # # One of the reasons that dlpar_cpu_offline can fail is when attempting to # offline the last online CPU of the kernel. This can be observed in a # pseries QEMU guest that has hotplugged CPUs. If the user offlines all # other CPUs of the guest, and a hotplugged CPU is now the last online # CPU, trying to reclaim it will fail. # # The current error message in this situation returns rc with -EBUSY and a # generic explanation, e.g.: # # pseries-hotplug-cpu: Failed to offline CPU PowerPC,POWER9, rc: -16 # # EBUSY can be caused by other conditions, such as cpu_hotplug_disable # being true. Throwing a more specific error message for this case, # instead of just "Failed to offline CPU", makes it clearer that the error # is in fact a known error situation instead of other generic/unknown # cause. # # This patch adds a 'last online' check in dlpar_cpu_offline() to catch # the 'last online CPU' offline error, eturning a more informative error # message: # # pseries-hotplug-cpu: Unable to remove last online CPU PowerPC,POWER9 # # Signed-off-by: Daniel Henrique Barboza # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210323205056.52768-2-danielhb413@gmail.com # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 07a361072378fb3ae116db86244372dbd68f9ea3 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xE9A3E9CA # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:3902:warning: override: reassigning to symbol STANDALONE .config:3904:warning: override: reassigning to symbol MODULE_SIG .config:3905:warning: override: reassigning to symbol CPU_BIG_ENDIAN .config:3905:warning: override: CPU_BIG_ENDIAN changes choice state .config:3914:warning: override: reassigning to symbol UBSAN # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/mm/memory.c:90:2: warning: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Wcpp] 90 | #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. | ^~~~~~~ /kisskb/src/mm/memory.c:90:2: warning: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Wcpp] 90 | #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. | ^~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 # Build took: 0:03:23.594163