# git rev-parse -q --verify 5e46d1b78a03d52306f21f77a4e4a144b6d31486^{commit} 5e46d1b78a03d52306f21f77a4e4a144b6d31486 already have revision, skipping fetch # git checkout -q -f -B kisskb 5e46d1b78a03d52306f21f77a4e4a144b6d31486 # git clean -qxdf # < git log -1 # commit 5e46d1b78a03d52306f21f77a4e4a144b6d31486 # Author: Tetsuo Handa # Date: Sun Mar 21 23:37:49 2021 +0900 # # reiserfs: update reiserfs_xattrs_initialized() condition # # syzbot is reporting NULL pointer dereference at reiserfs_security_init() # [1], for commit ab17c4f02156c4f7 ("reiserfs: fixup xattr_root caching") # is assuming that REISERFS_SB(s)->xattr_root != NULL in # reiserfs_xattr_jcreate_nblocks() despite that commit made # REISERFS_SB(sb)->priv_root != NULL && REISERFS_SB(s)->xattr_root == NULL # case possible. # # I guess that commit 6cb4aff0a77cc0e6 ("reiserfs: fix oops while creating # privroot with selinux enabled") wanted to check xattr_root != NULL # before reiserfs_xattr_jcreate_nblocks(), for the changelog is talking # about the xattr root. # # The issue is that while creating the privroot during mount # reiserfs_security_init calls reiserfs_xattr_jcreate_nblocks which # dereferences the xattr root. The xattr root doesn't exist, so we get # an oops. # # Therefore, update reiserfs_xattrs_initialized() to check both the # privroot and the xattr root. # # Link: https://syzkaller.appspot.com/bug?id=8abaedbdeb32c861dc5340544284167dd0e46cde # [1] # Reported-and-tested-by: syzbot # Signed-off-by: Tetsuo Handa # Fixes: 6cb4aff0a77c ("reiserfs: fix oops while creating privroot with selinux enabled") # Acked-by: Jeff Mahoney # Acked-by: Jan Kara # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 5e46d1b78a03d52306f21f77a4e4a144b6d31486 # < make -s -j 24 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 allmodconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_KCOV=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n # Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n # Added to kconfig CONFIG_UML_NET=n # Added to kconfig CONFIG_UML_NET_ETHERTAP=n # Added to kconfig CONFIG_UML_NET_TUNTAP=n # Added to kconfig CONFIG_UML_NET_SLIP=n # Added to kconfig CONFIG_UML_NET_DAEMON=n # Added to kconfig CONFIG_UML_NET_VDE=n # Added to kconfig CONFIG_UML_NET_MCAST=n # Added to kconfig CONFIG_UML_NET_PCAP=n # Added to kconfig CONFIG_UML_NET_SLIRP=n # Added to kconfig CONFIG_GCOV_KERNEL=n # Added to kconfig CONFIG_DEBUG_INFO_BTF=n # Added to kconfig CONFIG_BPF_PRELOAD=n # < make -s -j 24 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 help # make -s -j 24 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 olddefconfig .config:4529:warning: override: reassigning to symbol GCC_PLUGIN_CYC_COMPLEXITY .config:4531:warning: override: reassigning to symbol GCC_PLUGIN_LATENT_ENTROPY .config:4535:warning: override: reassigning to symbol UML_NET_ETHERTAP .config:4537:warning: override: reassigning to symbol UML_NET_SLIP .config:4540:warning: override: reassigning to symbol UML_NET_MCAST .config:4542:warning: override: reassigning to symbol UML_NET_SLIRP # make -s -j 24 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] cc1: warning: /kisskb/src/arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] LINK linux ERROR: modpost: "devm_ioremap_resource" [drivers/net/ethernet/xilinx/xilinx_emac.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/net/ethernet/xilinx/xilinx_emaclite.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource_byname" [drivers/net/ethernet/xilinx/ll_temac.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/net/ethernet/xilinx/ll_temac.ko] undefined! ERROR: modpost: "devm_of_iomap" [drivers/net/ethernet/xilinx/ll_temac.ko] undefined! make[2]: *** [/kisskb/src/scripts/Makefile.modpost:132: Module.symvers] Error 1 make[2]: *** Deleting file 'Module.symvers' make[1]: *** [/kisskb/src/Makefile:1442: modules] Error 2 make: *** [Makefile:215: __sub-make] Error 2 Command 'make -s -j 24 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_um-allmodconfig_um-x86_64 # Build took: 0:09:38.054054