Buildresult: gustavoars/sparc64-allmodconfig/sparc64-gcc5 built on Jun 18 2021, 03:18

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jun 18 2021, 03:18
Duration:	0:09:27.151895
Builder:	ka4
Revision:	media: siano: Fix out-of-bounds warnings in smscore_load_firmware_family2() (`305b46ebb0ead283ed6589172c91e851eb483141)`
Target:	gustavoars/sparc64-allmodconfig/sparc64-gcc5
Branch:	gustavoars
Compiler:	sparc64-gcc5 (sparc64-linux-gcc.br_real (Buildroot 2016.11-git-00613-ge98b4dd) 5.4.0 / GNU ld (GNU Binutils) 2.26.1)
Config:	allmodconfig (download)
Log:	Download original Possible warnings (4) <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] include/linux/minmax.h:18:28: warning: comparison of distinct pointer types lacks a cast drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. Full Log # git rev-parse -q --verify 305b46ebb0ead283ed6589172c91e851eb483141^{commit} 305b46ebb0ead283ed6589172c91e851eb483141 already have revision, skipping fetch # git checkout -q -f -B kisskb 305b46ebb0ead283ed6589172c91e851eb483141 # git clean -qxdf # < git log -1 # commit 305b46ebb0ead283ed6589172c91e851eb483141 # Author: Gustavo A. R. Silva <gustavoars@kernel.org> # Date: Wed Mar 10 19:40:43 2021 -0600 # # media: siano: Fix out-of-bounds warnings in smscore_load_firmware_family2() # # Rename struct sms_msg_data4 to sms_msg_data5 and increase the size of # its msg_data array from 4 to 5 elements. Notice that at some point # the 5th element of msg_data is being accessed in function # smscore_load_firmware_family2(): # # 1006 trigger_msg->msg_data[4] = 4; /* Task ID / # # Also, there is no need for the object _trigger_msg_ of type struct # sms_msg_data , when _msg_ can be used, directly. Notice that msg_data # in struct sms_msg_data is a one-element array, which causes multiple # out-of-bounds warnings when accessing beyond its first element # in function smscore_load_firmware_family2(): # # 992 struct sms_msg_data trigger_msg = # 993 (struct sms_msg_data ) msg; # 994 # 995 pr_debug("sending MSG_SMS_SWDOWNLOAD_TRIGGER_REQ\n"); # 996 SMS_INIT_MSG(&msg->x_msg_header, # 997 MSG_SMS_SWDOWNLOAD_TRIGGER_REQ, # 998 sizeof(struct sms_msg_hdr) + # 999 sizeof(u32) * 5); # 1000 # 1001 trigger_msg->msg_data[0] = firmware->start_address; # 1002 /* Entry point / # 1003 trigger_msg->msg_data[1] = 6; / Priority / # 1004 trigger_msg->msg_data[2] = 0x200; / Stack size / # 1005 trigger_msg->msg_data[3] = 0; / Parameter / # 1006 trigger_msg->msg_data[4] = 4; / Task ID / # # even when enough dynamic memory is allocated for _msg_: # # 929 / PAGE_SIZE buffer shall be enough and dma aligned / # 930 msg = kmalloc(PAGE_SIZE, GFP_KERNEL \| coredev->gfp_buf_flags); # # but as _msg_ is casted to (struct sms_msg_data ): # # 992 struct sms_msg_data trigger_msg = # 993 (struct sms_msg_data ) msg; # # the out-of-bounds warnings are actually valid and should be addressed. # # Fix this by declaring object _msg_ of type struct sms_msg_data5 , # which contains a 5-elements array, instead of just 4. And use # _msg_ directly, instead of creating object trigger_msg. # # This helps with the ongoing efforts to enable -Warray-bounds by fixing # the following warnings: # # CC [M] drivers/media/common/siano/smscoreapi.o # drivers/media/common/siano/smscoreapi.c: In function ‘smscore_load_firmware_family2’: # drivers/media/common/siano/smscoreapi.c:1003:24: warning: array subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] # 1003 \| trigger_msg->msg_data[1] = 6; / Priority / # \| ~~~~~~~~~~~~~~~~~~~~~^~~ # In file included from drivers/media/common/siano/smscoreapi.c:12: # drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ # 619 \| u32 msg_data[1]; # \| ^~~~~~~~ # drivers/media/common/siano/smscoreapi.c:1004:24: warning: array subscript 2 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] # 1004 \| trigger_msg->msg_data[2] = 0x200; / Stack size / # \| ~~~~~~~~~~~~~~~~~~~~~^~~ # In file included from drivers/media/common/siano/smscoreapi.c:12: # drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ # 619 \| u32 msg_data[1]; # \| ^~~~~~~~ # drivers/media/common/siano/smscoreapi.c:1005:24: warning: array subscript 3 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] # 1005 \| trigger_msg->msg_data[3] = 0; / Parameter / # \| ~~~~~~~~~~~~~~~~~~~~~^~~ # In file included from drivers/media/common/siano/smscoreapi.c:12: # drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ # 619 \| u32 msg_data[1]; # \| ^~~~~~~~ # drivers/media/common/siano/smscoreapi.c:1006:24: warning: array subscript 4 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] # 1006 \| trigger_msg->msg_data[4] = 4; / Task ID / # \| ~~~~~~~~~~~~~~~~~~~~~^~~ # In file included from drivers/media/common/siano/smscoreapi.c:12: # drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ # 619 \| u32 msg_data[1]; # \| ^~~~~~~~ # # Fixes: 018b0c6f8acb ("[media] siano: make load firmware logic to work with newer firmwares") # Co-developed-by: Kees Cook <keescook@chromium.org> # Signed-off-by: Kees Cook <keescook@chromium.org> # Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> # < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-gcc --version # < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-ld --version # < git log --format=%s --max-count=1 305b46ebb0ead283ed6589172c91e851eb483141 # < make -s -j 120 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MODULE_SIG=n # < make -s -j 120 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- help # make -s -j 120 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- olddefconfig # make -s -j 120 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/include/linux/kernel.h:15:0, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/gpu/drm/ttm/ttm_pool.c:34: /kisskb/src/drivers/gpu/drm/ttm/ttm_pool.c: In function 'ttm_pool_alloc': /kisskb/src/include/linux/minmax.h:18:28: warning: comparison of distinct pointer types lacks a cast (!!(sizeof((typeof(x) )1 == (typeof(y) *)1))) ^ /kisskb/src/include/linux/minmax.h:32:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^ /kisskb/src/include/linux/minmax.h:42:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^ /kisskb/src/include/linux/minmax.h:51:19: note: in expansion of macro '__careful_cmp' #define min(x, y) __careful_cmp(x, y, <) ^ /kisskb/src/drivers/gpu/drm/ttm/ttm_pool.c:386:15: note: in expansion of macro 'min' for (order = min(MAX_ORDER - 1UL, __fls(num_pages)); num_pages; ^ /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^ kernel: arch/sparc/boot/image is ready kernel: arch/sparc/boot/zImage is ready Completed OK # rm -rf /kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 # Build took: 0:09:27.151895

© Michael Ellerman 2006-2018.