# git rev-parse -q --verify 60b7ed54a41b550d50caf7f2418db4a7e75b5bdc^{commit} 60b7ed54a41b550d50caf7f2418db4a7e75b5bdc already have revision, skipping fetch # git checkout -q -f -B kisskb 60b7ed54a41b550d50caf7f2418db4a7e75b5bdc # git clean -qxdf # < git log -1 # commit 60b7ed54a41b550d50caf7f2418db4a7e75b5bdc # Author: Athira Rajeev # Date: Thu Jun 17 13:55:06 2021 -0400 # # powerpc/perf: Fix crash in perf_instruction_pointer() when ppmu is not set # # On systems without any specific PMU driver support registered, running # perf record causes Oops. # # The relevant portion from call trace: # # BUG: Kernel NULL pointer dereference on read at 0x00000040 # Faulting instruction address: 0xc0021f0c # Oops: Kernel access of bad area, sig: 11 [#1] # BE PAGE_SIZE=4K PREEMPT CMPCPRO # SAF3000 DIE NOTIFICATION # CPU: 0 PID: 442 Comm: null_syscall Not tainted 5.13.0-rc6-s3k-dev-01645-g7649ee3d2957 #5164 # NIP: c0021f0c LR: c00e8ad8 CTR: c00d8a5c # NIP perf_instruction_pointer+0x10/0x60 # LR perf_prepare_sample+0x344/0x674 # Call Trace: # perf_prepare_sample+0x7c/0x674 (unreliable) # perf_event_output_forward+0x3c/0x94 # __perf_event_overflow+0x74/0x14c # perf_swevent_hrtimer+0xf8/0x170 # __hrtimer_run_queues.constprop.0+0x160/0x318 # hrtimer_interrupt+0x148/0x3b0 # timer_interrupt+0xc4/0x22c # Decrementer_virt+0xb8/0xbc # # During perf record session, perf_instruction_pointer() is called to # capture the sample IP. This function in core-book3s accesses # ppmu->flags. If a platform specific PMU driver is not registered, ppmu # is set to NULL and accessing its members results in a crash. Fix this # crash by checking if ppmu is set. # # Fixes: 2ca13a4cc56c ("powerpc/perf: Use regs->nip when SIAR is zero") # Cc: stable@vger.kernel.org # v5.11+ # Reported-by: Christophe Leroy # Signed-off-by: Athira Rajeev # Tested-by: Christophe Leroy # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/1623952506-1431-1-git-send-email-atrajeev@linux.vnet.ibm.com # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 60b7ed54a41b550d50caf7f2418db4a7e75b5bdc # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/net/sched/sch_frag.c: In function 'sch_fragment': /kisskb/src/net/sched/sch_frag.c:93:10: warning: missing braces around initializer [-Wmissing-braces] struct rtable sch_frag_rt = { 0 }; ^ /kisskb/src/net/sched/sch_frag.c:93:10: warning: (near initialization for 'sch_frag_rt.dst') [-Wmissing-braces] In file included from /kisskb/src/include/linux/kernel.h:11:0, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd74ef0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd647c4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6541583 Bytes = 6388.26 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6541867 Bytes = 6388.54 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6543717 Bytes = 6390.35 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6541619 Bytes = 6388.30 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6541511 Bytes = 6388.19 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542480 Bytes = 6389.14 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542432 Bytes = 6389.09 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6541582 Bytes = 6388.26 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542576 Bytes = 6389.23 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542417 Bytes = 6389.08 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542416 Bytes = 6389.08 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542023 Bytes = 6388.69 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6510604 Bytes = 6358.01 KiB = 6.21 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6542852 Bytes = 6389.50 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6541581 Bytes = 6388.26 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.13.0-rc2-g60b7ed54a41b Created: Sun Jun 20 12:35:03 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6543437 Bytes = 6390.08 KiB = 6.24 MiB Load Address: 00e00000 Entry Point: 00e002a4 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc4.9 # Build took: 0:02:28.434449