# git rev-parse -q --verify a180bd1d7e16173d965b263c5a536aa40afa2a2a^{commit} a180bd1d7e16173d965b263c5a536aa40afa2a2a already have revision, skipping fetch # git checkout -q -f -B kisskb a180bd1d7e16173d965b263c5a536aa40afa2a2a # git clean -qxdf # < git log -1 # commit a180bd1d7e16173d965b263c5a536aa40afa2a2a # Author: Linus Torvalds # Date: Sun Jul 4 16:12:42 2021 -0700 # # iov_iter: remove uaccess_kernel() warning from iov_iter_init() # # This warning was there to catch any architectures that still use # CONFIG_SET_FS, and that would mis-use iov_iter_init() for anything that # wasn't a proper user space pointer. So that # # WARN_ON_ONCE(uaccess_kernel()); # # makes perfect conceptual sense: you really shouldn't use a kernel # pointer with set_fs(KERNEL_DS) and then pass it to iov_iter_init(). # # HOWEVER. # # Guenter Roeck reports that this warning actually triggers in no-mmu # configurations of both ARM and m68k. And the reason isn't that they # pass in a kernel pointer under set_fs(KERNEL_DS) at all: the reason is # that in those configurations, "uaccess_kernel()" is simply not reliable. # # Those no-mmu setups set USER_DS and KERNEL_DS to the same values, so you # can't test for the difference. # # In particular, the no-mmu case for ARM does # # #define USER_DS KERNEL_DS # #define uaccess_kernel() (true) # # so USER_DS and KERNEL_DS have the same value, and uaccess_kernel() is # always trivially true. # # The m68k case is slightly different and not quite as obvious. It does # (spread out over multiple header files just to be extra exciting: # asm/processor.h, asm/segment.h and asm-generic/uaccess.h): # # #define TASK_SIZE (0xFFFFFFFFUL) # #define USER_DS MAKE_MM_SEG(TASK_SIZE) # #define KERNEL_DS MAKE_MM_SEG(~0UL) # #define get_fs() (current_thread_info()->addr_limit) # #define uaccess_kernel() (get_fs().seg == KERNEL_DS.seg) # # but the end result is the same: uaccess_kernel() will always be true, # because USER_DS and KERNEL_DS end up having the same value, even if that # value is defined differently. # # This is very arguably a misfeature in those implementations, but in the # end we don't really care. All modern architectures have gotten rid of # set_fs() already, and generic kernel code never uses it. And while the # sanity check was a nice idea, an architecture would have to go the extra # mile to actually break this. # # So this well-intentioned warning isn't really all that likely to find # anything but these known false positives, and as such just isn't worth # maintaining. # # Reported-by: Guenter Roeck # Fixes: 8cd54c1c8480 ("iov_iter: separate direction from flavour") # Cc: Matthew Wilcox # Cc: Al Viro # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 a180bd1d7e16173d965b263c5a536aa40afa2a2a # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc83xx_defconfig # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/block/genhd.c: In function 'diskstats_show': /kisskb/src/block/genhd.c:1182:1: warning: the frame size of 1120 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ /kisskb/src/net/sched/sch_frag.c: In function 'sch_fragment': /kisskb/src/net/sched/sch_frag.c:93:10: warning: missing braces around initializer [-Wmissing-braces] struct rtable sch_frag_rt = { 0 }; ^ /kisskb/src/net/sched/sch_frag.c:93:10: warning: (near initialization for 'sch_frag_rt.dst') [-Wmissing-braces] INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x820d78) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) INFO: Uncompressed kernel (size 0x810768) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3666538 Bytes = 3580.60 KiB = 3.50 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3697229 Bytes = 3610.58 KiB = 3.53 MiB Load Address: 00900000 Entry Point: 00900294 Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3696912 Bytes = 3610.27 KiB = 3.53 MiB Load Address: 00900000 Entry Point: 00900294 Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3696361 Bytes = 3609.73 KiB = 3.53 MiB Load Address: 00900000 Entry Point: 00900294 Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3695314 Bytes = 3608.71 KiB = 3.52 MiB Load Address: 00900000 Entry Point: 00900294 Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3696535 Bytes = 3609.90 KiB = 3.53 MiB Load Address: 00900000 Entry Point: 00900294 Image Name: Linux-5.13.0-ga180bd1d7e16 Created: Fri Jul 16 15:36:33 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3695295 Bytes = 3608.69 KiB = 3.52 MiB Load Address: 00900000 Entry Point: 00900294 Completed OK # rm -rf /kisskb/build/linus_mpc83xx_defconfig_powerpc-gcc4.9 # Build took: 0:01:13.674458