Buildresult: linus/m68k-defconfig/m68k-gcc8 built on Jul 18 2021, 02:40

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 18 2021, 02:40
Duration:	0:00:33.963221
Builder:	alpine1
Revision:	Revert "Makefile: Enable -Wimplicit-fallthrough for Clang" (`d936eb23874433caa3e3d841cfa16f5434b85dcf)`
Target:	linus/m68k-defconfig/m68k-gcc8
Branch:	linus
Compiler:	m68k-gcc8 (m68k-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30)
Config:	defconfig (download)
Log:	Download original Possible warnings (12) arch/m68k/mvme147/config.c:174:2: warning: #warning check me! [-Wcpp] #warning check me! arch/m68k/mvme16x/config.c:439:2: warning: #warning check me! [-Wcpp] #warning check me! drivers/net/ethernet/8390/lib8390.c:995:27: warning: '____alloc_ei_netdev' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:957:13: warning: '__ei_set_multicast_list' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:857:33: warning: '__ei_get_stats' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:512:13: warning: '__ei_poll' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:303:20: warning: '__ei_start_xmit' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:257:13: warning: '__ei_tx_timeout' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:233:12: warning: '__ei_close' defined but not used [-Wunused-function] drivers/net/ethernet/8390/lib8390.c:204:12: warning: '__ei_open' defined but not used [-Wunused-function] Full Log # git rev-parse -q --verify d936eb23874433caa3e3d841cfa16f5434b85dcf^{commit} d936eb23874433caa3e3d841cfa16f5434b85dcf already have revision, skipping fetch # git checkout -q -f -B kisskb d936eb23874433caa3e3d841cfa16f5434b85dcf # git clean -qxdf # < git log -1 # commit d936eb23874433caa3e3d841cfa16f5434b85dcf # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Thu Jul 15 18:05:31 2021 -0700 # # Revert "Makefile: Enable -Wimplicit-fallthrough for Clang" # # This reverts commit b7eb335e26a9c7f258c96b3962c283c379d3ede0. # # It turns out that the problem with the clang -Wimplicit-fallthrough # warning is not about the kernel source code, but about clang itself, and # that the warning is unusable until clang fixes its broken ways. # # In particular, when you enable this warning for clang, you not only get # warnings about implicit fallthroughs. You also get this: # # warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough] # # which is completely broken becasue it # # (a) doesn't even tell you where the problem is (seriously: no line # numbers, no filename, no nothing). # # (b) is fundamentally broken anyway, because there are perfectly valid # reasons to have a fallthrough statement even if it turns out that # it can perhaps not be reached. # # In the kernel, an example of that second case is code in the scheduler: # # switch (state) { # case cpuset: # if (IS_ENABLED(CONFIG_CPUSETS)) { # cpuset_cpus_allowed_fallback(p); # state = possible; # break; # } # fallthrough; # case possible: # # where if CONFIG_CPUSETS is enabled you actually never hit the # fallthrough case at all. But that in no way makes the fallthrough # wrong. # # So the warning is completely broken, and enabling it for clang is a very # bad idea. # # In the meantime, we can keep the gcc option enabled, and make the gcc # build use # # -Wimplicit-fallthrough=5 # # which means that we will at least continue to require a proper # fallthrough statement, and that gcc won't silently accept the magic # comment versions. Because gcc does this all correctly, and while the odd # "=5" part is kind of obscure, it's documented in [1]: # # "-Wimplicit-fallthrough=5 doesn’t recognize any comments as # fallthrough comments, only attributes disable the warning" # # so if clang ever fixes its bad behavior we can try enabling it there again. # # Link: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html [1] # Cc: Kees Cook <keescook@chromium.org> # Cc: Gustavo A. R. Silva <gustavoars@kernel.org> # Cc: Nathan Chancellor <nathan@kernel.org> # Cc: Nick Desaulniers <ndesaulniers@google.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 d936eb23874433caa3e3d841cfa16f5434b85dcf # < make -s -j 160 ARCH=m68k O=/kisskb/build/linus_m68k-defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- defconfig # < make -s -j 160 ARCH=m68k O=/kisskb/build/linus_m68k-defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 160 ARCH=m68k O=/kisskb/build/linus_m68k-defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 160 ARCH=m68k O=/kisskb/build/linus_m68k-defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- /kisskb/src/arch/m68k/mvme147/config.c: In function 'mvme147_hwclk': /kisskb/src/arch/m68k/mvme147/config.c:174:2: warning: #warning check me! [-Wcpp] #warning check me! ^~~~~~~ /kisskb/src/arch/m68k/mvme16x/config.c: In function 'mvme16x_hwclk': /kisskb/src/arch/m68k/mvme16x/config.c:439:2: warning: #warning check me! [-Wcpp] #warning check me! ^~~~~~~ In file included from /kisskb/src/drivers/net/ethernet/8390/xsurf100.c:48: /kisskb/src/drivers/net/ethernet/8390/lib8390.c:995:27: warning: '____alloc_ei_netdev' defined but not used [-Wunused-function] static struct net_device ____alloc_ei_netdev(int size) ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:957:13: warning: '__ei_set_multicast_list' defined but not used [-Wunused-function] static void __ei_set_multicast_list(struct net_device dev) ^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:857:33: warning: '__ei_get_stats' defined but not used [-Wunused-function] static struct net_device_stats __ei_get_stats(struct net_device dev) ^~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:512:13: warning: '__ei_poll' defined but not used [-Wunused-function] static void __ei_poll(struct net_device dev) ^~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:303:20: warning: '__ei_start_xmit' defined but not used [-Wunused-function] static netdev_tx_t __ei_start_xmit(struct sk_buff skb, ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:257:13: warning: '__ei_tx_timeout' defined but not used [-Wunused-function] static void __ei_tx_timeout(struct net_device dev, unsigned int txqueue) ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:233:12: warning: '__ei_close' defined but not used [-Wunused-function] static int __ei_close(struct net_device dev) ^~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:204:12: warning: '__ei_open' defined but not used [-Wunused-function] static int __ei_open(struct net_device *dev) ^~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_m68k-defconfig_m68k-gcc8 # Build took: 0:00:33.963221

© Michael Ellerman 2006-2018.