Buildresult: linus/mips-defconfig/mipsel-gcc5 built on Jul 31 2021, 10:48

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 31 2021, 10:48
Duration:	0:01:35.040162
Builder:	ka1
Revision:	pipe: make pipe writes always wake up readers (`3a34b13a88caeb2800ab44a4918f230041b37dd9)`
Target:	linus/mips-defconfig/mipsel-gcc5
Branch:	linus
Compiler:	mipsel-gcc5 (mipsel-linux-gcc.br_real (Buildroot 2016.11-git-00613-ge98b4dd) 5.4.0 / GNU ld (GNU Binutils) 2.26.1)
Config:	defconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 3a34b13a88caeb2800ab44a4918f230041b37dd9^{commit} 3a34b13a88caeb2800ab44a4918f230041b37dd9 already have revision, skipping fetch # git checkout -q -f -B kisskb 3a34b13a88caeb2800ab44a4918f230041b37dd9 # git clean -qxdf # < git log -1 # commit 3a34b13a88caeb2800ab44a4918f230041b37dd9 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Fri Jul 30 15:42:34 2021 -0700 # # pipe: make pipe writes always wake up readers # # Since commit 1b6b26ae7053 ("pipe: fix and clarify pipe write wakeup # logic") we have sanitized the pipe write logic, and would only try to # wake up readers if they needed it. # # In particular, if the pipe already had data in it before the write, # there was no point in trying to wake up a reader, since any existing # readers must have been aware of the pre-existing data already. Doing # extraneous wakeups will only cause potential thundering herd problems. # # However, it turns out that some Android libraries have misused the EPOLL # interface, and expected "edge triggered" be to "any new write will # trigger it". Even if there was no edge in sight. # # Quoting Sandeep Patil: # "The commit 1b6b26ae7053 ('pipe: fix and clarify pipe write wakeup # logic') changed pipe write logic to wakeup readers only if the pipe # was empty at the time of write. However, there are libraries that # relied upon the older behavior for notification scheme similar to # what's described in [1] # # One such library 'realm-core'[2] is used by numerous Android # applications. The library uses a similar notification mechanism as GNU # Make but it never drains the pipe until it is full. When Android moved # to v5.10 kernel, all applications using this library stopped working. # # The library has since been fixed[3] but it will be a while before all # applications incorporate the updated library" # # Our regression rule for the kernel is that if applications break from # new behavior, it's a regression, even if it was because the application # did something patently wrong. Also note the original report [4] by # Michal Kerrisk about a test for this epoll behavior - but at that point # we didn't know of any actual broken use case. # # So add the extraneous wakeup, to approximate the old behavior. # # [ I say "approximate", because the exact old behavior was to do a wakeup # not for each write(), but for each pipe buffer chunk that was filled # in. The behavior introduced by this change is not that - this is just # "every write will cause a wakeup, whether necessary or not", which # seems to be sufficient for the broken library use. ] # # It's worth noting that this adds the extraneous wakeup only for the # write side, while the read side still considers the "edge" to be purely # about reading enough from the pipe to allow further writes. # # See commit f467a6a66419 ("pipe: fix and clarify pipe read wakeup logic") # for the pipe read case, which remains that "only wake up if the pipe was # full, and we read something from it". # # Link: https://lore.kernel.org/lkml/CAHk-=wjeG0q1vgzu4iJhW5juPkTsjTYmiqiMUYAebWW+0bam6w@mail.gmail.com/ [1] # Link: https://github.com/realm/realm-core [2] # Link: https://github.com/realm/realm-core/issues/4666 [3] # Link: https://lore.kernel.org/lkml/CAKgNAkjMBGeAwF=2MKK758BhxvW58wYTgYKB2V-gY1PwXxrH+Q@mail.gmail.com/ [4] # Link: https://lore.kernel.org/lkml/20210729222635.2937453-1-sspatil@android.com/ # Reported-by: Sandeep Patil <sspatil@android.com> # Cc: Michael Kerrisk <mtk.manpages@gmail.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-ld --version # < git log --format=%s --max-count=1 3a34b13a88caeb2800ab44a4918f230041b37dd9 # < make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- defconfig # < make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- help # make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- olddefconfig # make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- Completed OK # rm -rf /kisskb/build/linus_mips-defconfig_mipsel # Build took: 0:01:35.040162

© Michael Ellerman 2006-2018.