# git rev-parse -q --verify a88603f4b92ecef9e2359e40bcb99ad399d85dd7^{commit} a88603f4b92ecef9e2359e40bcb99ad399d85dd7 already have revision, skipping fetch # git checkout -q -f -B kisskb a88603f4b92ecef9e2359e40bcb99ad399d85dd7 # git clean -qxdf # < git log -1 # commit a88603f4b92ecef9e2359e40bcb99ad399d85dd7 # Author: Michael Ellerman # Date: Thu Jul 29 22:56:36 2021 +1000 # # powerpc/vdso: Don't use r30 to avoid breaking Go lang # # The Go runtime uses r30 for some special value called 'g'. It assumes # that value will remain unchanged even when calling VDSO functions. # Although r30 is non-volatile across function calls, the callee is free # to use it, as long as the callee saves the value and restores it before # returning. # # It used to be true by accident that the VDSO didn't use r30, because the # VDSO was hand-written asm. When we switched to building the VDSO from C # the compiler started using r30, at least in some builds, leading to # crashes in Go. eg: # # ~/go/src$ ./all.bash # Building Go cmd/dist using /usr/lib/go-1.16. (go1.16.2 linux/ppc64le) # Building Go toolchain1 using /usr/lib/go-1.16. # go build os/exec: /usr/lib/go-1.16/pkg/tool/linux_ppc64le/compile: signal: segmentation fault # go build reflect: /usr/lib/go-1.16/pkg/tool/linux_ppc64le/compile: signal: segmentation fault # go tool dist: FAILED: /usr/lib/go-1.16/bin/go install -gcflags=-l -tags=math_big_pure_go compiler_bootstrap bootstrap/cmd/...: exit status 1 # # There are patches in flight to fix Go[1], but until they are released # and widely deployed we can workaround it in the VDSO by avoiding use of # r30. # # Note this only works with GCC, clang does not support -ffixed-rN. # # 1: https://go-review.googlesource.com/c/go/+/328110 # # Fixes: ab037dd87a2f ("powerpc/vdso: Switch VDSO to generic C implementation.") # Cc: stable@vger.kernel.org # v5.11+ # Reported-by: Paul Menzel # Tested-by: Paul Menzel # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210729131244.2595519-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 a88603f4b92ecef9e2359e40bcb99ad399d85dd7 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4237:warning: override: reassigning to symbol PPC_E500MC .config:4238:warning: override: reassigning to symbol VIRTUALIZATION # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 # Build took: 0:02:49.689996