# git rev-parse -q --verify fe67f4dd8daa252eb9aa7acb61555f3cc3c1ce4c^{commit} fe67f4dd8daa252eb9aa7acb61555f3cc3c1ce4c already have revision, skipping fetch # git checkout -q -f -B kisskb fe67f4dd8daa252eb9aa7acb61555f3cc3c1ce4c # git clean -qxdf # < git log -1 # commit fe67f4dd8daa252eb9aa7acb61555f3cc3c1ce4c # Author: Linus Torvalds # Date: Tue Aug 24 10:39:25 2021 -0700 # # pipe: do FASYNC notifications for every pipe IO, not just state changes # # It turns out that the SIGIO/FASYNC situation is almost exactly the same # as the EPOLLET case was: user space really wants to be notified after # every operation. # # Now, in a perfect world it should be sufficient to only notify user # space on "state transitions" when the IO state changes (ie when a pipe # goes from unreadable to readable, or from unwritable to writable). User # space should then do as much as possible - fully emptying the buffer or # what not - and we'll notify it again the next time the state changes. # # But as with EPOLLET, we have at least one case (stress-ng) where the # kernel sent SIGIO due to the pipe being marked for asynchronous # notification, but the user space signal handler then didn't actually # necessarily read it all before returning (it read more than what was # written, but since there could be multiple writes, it could leave data # pending). # # The user space code then expected to get another SIGIO for subsequent # writes - even though the pipe had been readable the whole time - and # would only then read more. # # This is arguably a user space bug - and Colin King already fixed the # stress-ng code in question - but the kernel regression rules are clear: # it doesn't matter if kernel people think that user space did something # silly and wrong. What matters is that it used to work. # # So if user space depends on specific historical kernel behavior, it's a # regression when that behavior changes. It's on us: we were silly to # have that non-optimal historical behavior, and our old kernel behavior # was what user space was tested against. # # Because of how the FASYNC notification was tied to wakeup behavior, this # was first broken by commits f467a6a66419 and 1b6b26ae7053 ("pipe: fix # and clarify pipe read/write wakeup logic"), but at the time it seems # nobody noticed. Probably because the stress-ng problem case ends up # being timing-dependent too. # # It was then unwittingly fixed by commit 3a34b13a88ca ("pipe: make pipe # writes always wake up readers") only to be broken again when by commit # 3b844826b6c6 ("pipe: avoid unnecessary EPOLLET wakeups under normal # loads"). # # And at that point the kernel test robot noticed the performance # refression in the stress-ng.sigio.ops_per_sec case. So the "Fixes" tag # below is somewhat ad hoc, but it matches when the issue was noticed. # # Fix it for good (knock wood) by simply making the kill_fasync() case # separate from the wakeup case. FASYNC is quite rare, and we clearly # shouldn't even try to use the "avoid unnecessary wakeups" logic for it. # # Link: https://lore.kernel.org/lkml/20210824151337.GC27667@xsang-OptiPlex-9020/ # Fixes: 3b844826b6c6 ("pipe: avoid unnecessary EPOLLET wakeups under normal loads") # Reported-by: kernel test robot # Tested-by: Oliver Sang # Cc: Eric Biederman # Cc: Colin Ian King # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 fe67f4dd8daa252eb9aa7acb61555f3cc3c1ce4c # < make -s -j 120 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 120 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 120 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 120 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- /kisskb/src/arch/m68k/mvme147/config.c: In function 'mvme147_hwclk': /kisskb/src/arch/m68k/mvme147/config.c:174:2: warning: #warning check me! [-Wcpp] #warning check me! ^~~~~~~ /kisskb/src/arch/m68k/mvme16x/config.c: In function 'mvme16x_hwclk': /kisskb/src/arch/m68k/mvme16x/config.c:439:2: warning: #warning check me! [-Wcpp] #warning check me! ^~~~~~~ /kisskb/src/arch/m68k/mvme16x/config.c:439:2: warning: #warning check me! [-Wcpp] #warning check me! ^~~~~~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:12: /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:20:2: note: in expansion of macro 'outb' outb((u8)data, (u16)(port + 0x378)); ^~~~ /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:26:9: note: in expansion of macro 'inb' data = inb((u16)(port + 0x378)); ^~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/include/asm-generic/hardirq.h:17, from ./arch/m68k/include/generated/asm/hardirq.h:1, from /kisskb/src/include/linux/hardirq.h:11, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/8390/wd.c:36: /kisskb/src/drivers/net/ethernet/8390/wd.c: In function 'wd_probe1': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:355:76: note: in expansion of macro 'out_8' #define outb_p(val, port) ((port) < 1024 ? isa_rom_outb_p((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/net/ethernet/8390/wd.c:289:4: note: in expansion of macro 'outb_p' outb_p(E8390_NODMA + E8390_STOP, nic_addr); ^~~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/net/ethernet/8390/wd.c:296:4: note: in expansion of macro 'outb' outb(E8390_RREAD+E8390_START, nic_addr); /* Trigger it... */ ^~~~ In file included from /kisskb/src/drivers/net/ethernet/8390/xsurf100.c:48: /kisskb/src/drivers/net/ethernet/8390/lib8390.c:995:27: warning: '____alloc_ei_netdev' defined but not used [-Wunused-function] static struct net_device *____alloc_ei_netdev(int size) ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:957:13: warning: '__ei_set_multicast_list' defined but not used [-Wunused-function] static void __ei_set_multicast_list(struct net_device *dev) ^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:857:33: warning: '__ei_get_stats' defined but not used [-Wunused-function] static struct net_device_stats *__ei_get_stats(struct net_device *dev) ^~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:512:13: warning: '__ei_poll' defined but not used [-Wunused-function] static void __ei_poll(struct net_device *dev) ^~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:303:20: warning: '__ei_start_xmit' defined but not used [-Wunused-function] static netdev_tx_t __ei_start_xmit(struct sk_buff *skb, ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:257:13: warning: '__ei_tx_timeout' defined but not used [-Wunused-function] static void __ei_tx_timeout(struct net_device *dev, unsigned int txqueue) ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:233:12: warning: '__ei_close' defined but not used [-Wunused-function] static int __ei_close(struct net_device *dev) ^~~~~~~~~~ /kisskb/src/drivers/net/ethernet/8390/lib8390.c:204:12: warning: '__ei_open' defined but not used [-Wunused-function] static int __ei_open(struct net_device *dev) ^~~~~~~~~ /kisskb/src/drivers/gpu/drm/rockchip/cdn-dp-core.c:1126:12: warning: 'cdn_dp_resume' defined but not used [-Wunused-function] static int cdn_dp_resume(struct device *dev) ^~~~~~~~~~~~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/include/asm-generic/hardirq.h:17, from ./arch/m68k/include/generated/asm/hardirq.h:1, from /kisskb/src/include/linux/hardirq.h:11, from /kisskb/src/include/linux/highmem.h:10, from /kisskb/src/include/linux/bio.h:8, from /kisskb/src/include/linux/blkdev.h:18, from /kisskb/src/drivers/scsi/ppa.c:15: /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_byte_out': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/ppa.h:137:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/ppa.c:245:3: note: in expansion of macro 'w_dtr' w_dtr(base, *buffer++); ^~~~~ /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_byte_in': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/scsi/ppa.h:129:40: note: in expansion of macro 'inb' #define r_dtr(x) (unsigned char)inb((x)) ^~~ /kisskb/src/drivers/scsi/ppa.c:257:15: note: in expansion of macro 'r_dtr' *buffer++ = r_dtr(base); ^~~~~ /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_d_pulse': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/ppa.h:137:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/ppa.c:379:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, b); ^~~~~ /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_c_pulse': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/ppa.h:137:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/ppa.c:399:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, b); ^~~~~ /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_select': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/ppa.h:137:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/ppa.c:436:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, (1 << target)); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/ppa.h:137:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/ppa.c:439:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0x80); /* This is NOT the initator */ ^~~~~ /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/include/asm-generic/hardirq.h:17, from ./arch/m68k/include/generated/asm/hardirq.h:1, from /kisskb/src/include/linux/hardirq.h:11, from /kisskb/src/include/linux/highmem.h:10, from /kisskb/src/include/linux/bio.h:8, from /kisskb/src/include/linux/blkdev.h:18, from /kisskb/src/drivers/scsi/imm.c:15: /kisskb/src/drivers/scsi/imm.c: In function 'imm_negotiate': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:248:2: note: in expansion of macro 'w_dtr' w_dtr(base, mode); ^~~~~ /kisskb/src/drivers/scsi/imm.c: In function 'imm_byte_out': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:304:3: note: in expansion of macro 'w_dtr' w_dtr(base, *buffer++); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:306:3: note: in expansion of macro 'w_dtr' w_dtr(base, *buffer++); ^~~~~ /kisskb/src/drivers/scsi/imm.c: In function 'imm_byte_in': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/scsi/imm.h:122:40: note: in expansion of macro 'inb' #define r_dtr(x) (unsigned char)inb((x)) ^~~ /kisskb/src/drivers/scsi/imm.c:342:15: note: in expansion of macro 'r_dtr' *buffer++ = r_dtr(base); ^~~~~ /kisskb/src/drivers/scsi/imm.c: In function 'imm_cpp': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:462:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0xaa); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:464:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0x55); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:466:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0x00); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:468:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0xff); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:471:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0x87); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:474:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0x78); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:487:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, b); ^~~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:495:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0xff); ^~~~~ /kisskb/src/drivers/scsi/imm.c: In function 'imm_select': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/scsi/imm.h:130:25: note: in expansion of macro 'outb' #define w_dtr(x,y) outb(y, (x)) ^~~~ /kisskb/src/drivers/scsi/imm.c:564:2: note: in expansion of macro 'w_dtr' w_dtr(ppb, 0x80 | (1 << target)); ^~~~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/drivers/block/paride/bpck6.c:30: /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_select': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:131:18: note: in expansion of macro 'inb' ppc->org_data = inb(ppc->lpt_addr); ^~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:142:3: note: in expansion of macro 'outb' outb('x', ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:144:2: note: in expansion of macro 'outb' outb('b', ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:145:2: note: in expansion of macro 'outb' outb('p', ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:146:2: note: in expansion of macro 'outb' outb(ppc->ppc_id, ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:147:2: note: in expansion of macro 'outb' outb(~ppc->ppc_id,ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:162:2: note: in expansion of macro 'outb' outb(i, ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:201:2: note: in expansion of macro 'outb' outb(ppc->org_data, ppc->lpt_addr); ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_deselect': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:217:2: note: in expansion of macro 'outb' outb(ppc->org_data, ppc->lpt_addr); ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_send_cmd': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:235:4: note: in expansion of macro 'outb' outb(cmd, ppc->lpt_addr); ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_wr_data_byte': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:266:4: note: in expansion of macro 'outb' outb(data, ppc->lpt_addr); ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_rd_data_byte': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:329:11: note: in expansion of macro 'inb' data = inb(ppc->lpt_addr); ^~~ /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_rd_data_blk': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:430:15: note: in expansion of macro 'inb' *data++ = inb(ppc->lpt_addr); ^~~ /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_wr_data_blk': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:537:5: note: in expansion of macro 'outb' outb(*data++, ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:560:4: note: in expansion of macro 'outb' outb(last, ppc->lpt_addr); ^~~~ /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/block/paride/ppc6lnx.c:575:6: note: in expansion of macro 'outb' outb(this, ppc->lpt_addr); ^~~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/drivers/hwmon/sch56xx-common.c:13: /kisskb/src/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_send_cmd': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/hwmon/sch56xx-common.c:132:2: note: in expansion of macro 'outb' outb(0x01, addr); /* Write 01h to the Host-to-EC register */ ^~~~ In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/drivers/hwmon/smsc47b397.c:29: /kisskb/src/drivers/hwmon/smsc47b397.c: In function 'smsc47b397_read_value': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/hwmon/smsc47b397.c:111:2: note: in expansion of macro 'outb' outb(reg, data->addr); ^~~~ Completed OK # rm -rf /kisskb/build/linus_m68k-allmodconfig_m68k-gcc8 # Build took: 0:07:17.580177