# git rev-parse -q --verify c7dee506ec3450717e84518ab3a6a3f2ce755cf6^{commit} c7dee506ec3450717e84518ab3a6a3f2ce755cf6 already have revision, skipping fetch # git checkout -q -f -B kisskb c7dee506ec3450717e84518ab3a6a3f2ce755cf6 # git clean -qxdf # < git log -1 # commit c7dee506ec3450717e84518ab3a6a3f2ce755cf6 # Author: Michael Ellerman # Date: Tue Aug 31 23:41:15 2021 +1000 # # powerpc/ptdump: Fix generic ptdump for 64-bit # # Since the conversion to generic ptdump we see crashes on 64-bit: # # BUG: Unable to handle kernel data access on read at 0xc0eeff7f00000000 # Faulting instruction address: 0xc00000000045e5fc # Oops: Kernel access of bad area, sig: 11 [#1] # ... # NIP __walk_page_range+0x2bc/0xce0 # LR __walk_page_range+0x240/0xce0 # Call Trace: # __walk_page_range+0x240/0xce0 (unreliable) # walk_page_range_novma+0x74/0xb0 # ptdump_walk_pgd+0x98/0x170 # ptdump_check_wx+0x88/0xd0 # mark_rodata_ro+0x48/0x80 # kernel_init+0x74/0x1a0 # ret_from_kernel_thread+0x5c/0x64 # # What's happening is that have walked off the end of the kernel page # tables, and started dereferencing junk values. # # That happens because we initialised the ptdump_range to span all the way # up to 0xffffffffffffffff: # # static struct ptdump_range ptdump_range[] __ro_after_init = { # {TASK_SIZE_MAX, ~0UL}, # # But the kernel page tables don't span that far. So on 64-bit set the end # of the range to be the address immediately past the end of the kernel # page tables, to limit the page table walk to valid addresses. # # Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") # Reported-by: Nathan Chancellor # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 c7dee506ec3450717e84518ab3a6a3f2ce755cf6 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_TM_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc64_defconfig # Added to kconfig CONFIG_PPC_TRANSACTIONAL_MEM=n # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_TM_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_TM_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_TM_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/net/sched/sch_frag.c: In function 'sch_fragment': /kisskb/src/net/sched/sch_frag.c:93:10: warning: missing braces around initializer [-Wmissing-braces] struct rtable sch_frag_rt = { 0 }; ^ /kisskb/src/net/sched/sch_frag.c:93:10: warning: (near initialization for 'sch_frag_rt.dst') [-Wmissing-braces] /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/sge.c: In function 'cxgb4_write_partial_sgl': /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/sge.c:910:9: warning: missing braces around initializer [-Wmissing-braces] struct ulptx_sge_pair buf[MAX_SKB_FRAGS / 2 + 1] = {0}, *to; ^ /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/sge.c:910:9: warning: (near initialization for 'buf[0]') [-Wmissing-braces] /kisskb/src/fs/btrfs/tree-checker.c: In function 'check_root_item': /kisskb/src/fs/btrfs/tree-checker.c:1071:9: warning: missing braces around initializer [-Wmissing-braces] struct btrfs_root_item ri = { 0 }; ^ /kisskb/src/fs/btrfs/tree-checker.c:1071:9: warning: (near initialization for 'ri.inode') [-Wmissing-braces] Completed OK # rm -rf /kisskb/build/powerpc-next_ppc64_defconfig+NO_TM_powerpc-gcc4.9 # Build took: 0:02:20.662113