# git rev-parse -q --verify 1619b69edce14c4a4665fa8ff4c587dcc77202a9^{commit}
1619b69edce14c4a4665fa8ff4c587dcc77202a9
already have revision, skipping fetch
# git checkout -q -f -B kisskb 1619b69edce14c4a4665fa8ff4c587dcc77202a9
# git clean -qxdf
# < git log -1
# commit 1619b69edce14c4a4665fa8ff4c587dcc77202a9
# Author: Michael Ellerman <mpe@ellerman.id.au>
# Date:   Tue Sep 14 22:17:23 2021 +1000
# 
#     powerpc/boot: Fix build failure since GCC 4.9 removal
#     
#     Stephen reported that the build was broken since commit
#     6d2ef226f2f1 ("compiler_attributes.h: drop __has_attribute() support for
#     gcc4"), with errors such as:
#     
#       include/linux/compiler_attributes.h:296:5: warning: "__has_attribute" is not defined, evaluates to 0 [-Wundef]
#         296 | #if __has_attribute(__warning__)
#             |     ^~~~~~~~~~~~~~~
#       make[2]: *** [arch/powerpc/boot/Makefile:225: arch/powerpc/boot/crt0.o] Error 1
#     
#     But we expect __has_attribute() to always be defined now that we've
#     stopped using GCC 4.
#     
#     Linus debugged it to the point of reading the GCC sources, and noticing
#     that the problem is that __has_attribute() is not defined when
#     preprocessing assembly files, which is what we're doing here.
#     
#     Our assembly files don't include, or need, compiler_attributes.h, but
#     they are getting it unconditionally from the -include in BOOT_CFLAGS,
#     which is then added in its entirety to BOOT_AFLAGS.
#     
#     That -include was added in commit 77433830ed16 ("powerpc: boot: include
#     compiler_attributes.h") so that we'd have "fallthrough" and other
#     attributes defined for the C files in arch/powerpc/boot. But it's not
#     needed for assembly files.
#     
#     The minimal fix is to move the addition to BOOT_CFLAGS of -include
#     compiler_attributes.h until after we've copied BOOT_CFLAGS into
#     BOOT_AFLAGS. That avoids including compiler_attributes.h for asm files,
#     but makes no other change to BOOT_CFLAGS or BOOT_AFLAGS.
#     
#     Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
#     Debugged-by: Linus Torvalds <torvalds@linux-foundation.org>
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
#     Tested-by: Guenter Roeck <linux@roeck-us.net>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld --version
# < git log --format=%s --max-count=1 1619b69edce14c4a4665fa8ff4c587dcc77202a9
# < make -s -j 120 ARCH=nds32 O=/kisskb/build/linus_nds32-allnoconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-  allnoconfig
# < make -s -j 120 ARCH=nds32 O=/kisskb/build/linus_nds32-allnoconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-  help
# make -s -j 120 ARCH=nds32 O=/kisskb/build/linus_nds32-allnoconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-  olddefconfig
# make -s -j 120 ARCH=nds32 O=/kisskb/build/linus_nds32-allnoconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-  
<stdin>:1515:2: warning: #warning syscall clone3 not implemented [-Wcpp]
Completed OK
# rm -rf /kisskb/build/linus_nds32-allnoconfig_nds32le-gcc8
# Build took: 0:00:19.592027