# git rev-parse -q --verify b7213ffa0e585feb1aee3e7173e965e66ee0abaa^{commit} b7213ffa0e585feb1aee3e7173e965e66ee0abaa already have revision, skipping fetch # git checkout -q -f -B kisskb b7213ffa0e585feb1aee3e7173e965e66ee0abaa # git clean -qxdf # < git log -1 # commit b7213ffa0e585feb1aee3e7173e965e66ee0abaa # Author: Linus Torvalds # Date: Wed Sep 15 13:56:37 2021 -0700 # # qnx4: avoid stringop-overread errors # # The qnx4 directory entries are 64-byte blocks that have different # contents depending on the a status byte that is in the last byte of the # block. # # In particular, a directory entry can be either a "link info" entry with # a 48-byte name and pointers to the real inode information, or an "inode # entry" with a smaller 16-byte name and the full inode information. # # But the code was written to always just treat the directory name as if # it was part of that "inode entry", and just extend the name to the # longer case if the status byte said it was a link entry. # # That work just fine and gives the right results, but now that gcc is # tracking data structure accesses much more, the code can trigger a # compiler error about using up to 48 bytes (the long name) in a structure # that only has that shorter name in it: # # fs/qnx4/dir.c: In function ‘qnx4_readdir’: # fs/qnx4/dir.c:51:32: error: ‘strnlen’ specified bound 48 exceeds source size 16 [-Werror=stringop-overread] # 51 | size = strnlen(de->di_fname, size); # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ # In file included from fs/qnx4/qnx4.h:3, # from fs/qnx4/dir.c:16: # include/uapi/linux/qnx4_fs.h:45:25: note: source object declared here # 45 | char di_fname[QNX4_SHORT_NAME_MAX]; # | ^~~~~~~~ # # which is because the source code doesn't really make this whole "one of # two different types" explicit. # # Fix this by introducing a very explicit union of the two types, and # basically explaining to the compiler what is really going on. # # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 b7213ffa0e585feb1aee3e7173e965e66ee0abaa # < make -s -j 8 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 8 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- help # make -s -j 8 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- olddefconfig # make -s -j 8 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- /kisskb/src/drivers/spi/spi-tegra20-slink.c:1200:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function] static int tegra_slink_runtime_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/spi/spi-tegra20-slink.c:1188:12: error: 'tegra_slink_runtime_suspend' defined but not used [-Werror=unused-function] static int tegra_slink_runtime_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/spi/spi-tegra20-slink.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/spi] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/lib/xxhash.c: In function 'xxh64': /kisskb/src/lib/xxhash.c:236:1: error: the frame size of 1624 bytes is larger than 1536 bytes [-Werror=frame-larger-than=] } ^ In file included from /kisskb/src/drivers/net/phy/dp83640.c:23: /kisskb/src/drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined [-Werror] #define PAGE0 0x0000 In file included from /kisskb/src/include/linux/mm_types_task.h:16, from /kisskb/src/include/linux/mm_types.h:5, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/fs.h:15, from /kisskb/src/include/linux/compat.h:17, from /kisskb/src/include/linux/ethtool.h:17, from /kisskb/src/drivers/net/phy/dp83640.c:11: /kisskb/src/arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition #define PAGE0 ((struct zeropage *)__PAGE_OFFSET) cc1: all warnings being treated as errors make[2]: *** [/kisskb/src/scripts/Makefile.build:277: lib/xxhash.o] Error 1 make[1]: *** [/kisskb/src/Makefile:1868: lib] Error 2 make[1]: *** Waiting for unfinished jobs.... cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/net/phy/dp83640.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/net/phy] Error 2 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/scsi/ncr53c8xx.c:8000:26: error: 'retrieve_from_waiting_list' defined but not used [-Werror=unused-function] static struct scsi_cmnd *retrieve_from_waiting_list(int to_remove, struct ncb *np, struct scsi_cmnd *cmd) ^~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/scsi/ncr53c8xx.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/scsi] Error 2 /kisskb/src/drivers/gpu/drm/rockchip/cdn-dp-core.c:1126:12: error: 'cdn_dp_resume' defined but not used [-Werror=unused-function] static int cdn_dp_resume(struct device *dev) ^~~~~~~~~~~~~ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/gpu/drm/rockchip/cdn-dp-core.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu/drm/rockchip] Error 2 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c: In function 'nvkm_control_mthd_pstate_info': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c:60:21: error: overflow in conversion from 'int' to '__s8' {aka 'signed char'} changes value from '-251' to '5' [-Werror=overflow] args->v0.pwrsrc = -ENOSYS; ^ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu/drm/nouveau] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu/drm] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/net] Error 2 make[1]: *** [/kisskb/src/Makefile:1868: drivers] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 8 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 # Build took: 0:17:37.129680