# git rev-parse -q --verify 8881af30b4211dbbe141d6e0ee2251d45c538dc7^{commit} 8881af30b4211dbbe141d6e0ee2251d45c538dc7 already have revision, skipping fetch # git checkout -q -f -B kisskb 8881af30b4211dbbe141d6e0ee2251d45c538dc7 # git clean -qxdf # < git log -1 # commit 8881af30b4211dbbe141d6e0ee2251d45c538dc7 # Author: Gustavo A. R. Silva # Date: Mon Sep 13 16:45:28 2021 -0500 # # Makefile: Enable -Wimplicit-fallthrough for Clang # # With the recent fixes for fallthrough warnings, it is now possible to # enable -Wimplicit-fallthrough for Clang. # # Special thanks to Nathan Chancellor who fixed the Clang bug[1][2] # that put the application of this patch to a halt, temporarily. This # bugfix only appears in Clang 14.0.0, so older versions still contain # the bug and -Wimplicit-fallthrough won't be enabled for them, for # now. # # This concludes a long journey and now we are finally getting rid # of the unintentional fallthrough bug-class in the kernel, entirely. :) # # [1] https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8 # [2] https://bugs.llvm.org/show_bug.cgi?id=51094 # # Link: https://github.com/KSPP/linux/issues/115 # Link: https://github.com/ClangBuiltLinux/linux/issues/236 # [The conditional "ifneq" was idea of Nathan] # Suggested-by: Nathan Chancellor # Reviewed-by: Nathan Chancellor # Tested-by: Nathan Chancellor # Co-developed-by: Kees Cook # Signed-off-by: Kees Cook # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 8881af30b4211dbbe141d6e0ee2251d45c538dc7 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 24 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 24 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) Completed OK # rm -rf /kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 # Build took: 0:03:34.130321