# git rev-parse -q --verify 8881af30b4211dbbe141d6e0ee2251d45c538dc7^{commit} 8881af30b4211dbbe141d6e0ee2251d45c538dc7 already have revision, skipping fetch # git checkout -q -f -B kisskb 8881af30b4211dbbe141d6e0ee2251d45c538dc7 # git clean -qxdf # < git log -1 # commit 8881af30b4211dbbe141d6e0ee2251d45c538dc7 # Author: Gustavo A. R. Silva # Date: Mon Sep 13 16:45:28 2021 -0500 # # Makefile: Enable -Wimplicit-fallthrough for Clang # # With the recent fixes for fallthrough warnings, it is now possible to # enable -Wimplicit-fallthrough for Clang. # # Special thanks to Nathan Chancellor who fixed the Clang bug[1][2] # that put the application of this patch to a halt, temporarily. This # bugfix only appears in Clang 14.0.0, so older versions still contain # the bug and -Wimplicit-fallthrough won't be enabled for them, for # now. # # This concludes a long journey and now we are finally getting rid # of the unintentional fallthrough bug-class in the kernel, entirely. :) # # [1] https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8 # [2] https://bugs.llvm.org/show_bug.cgi?id=51094 # # Link: https://github.com/KSPP/linux/issues/115 # Link: https://github.com/ClangBuiltLinux/linux/issues/236 # [The conditional "ifneq" was idea of Nathan] # Suggested-by: Nathan Chancellor # Reviewed-by: Nathan Chancellor # Tested-by: Nathan Chancellor # Co-developed-by: Kees Cook # Signed-off-by: Kees Cook # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 8881af30b4211dbbe141d6e0ee2251d45c538dc7 # < make -s -j 32 ARCH=m68k O=/kisskb/build/gustavoars_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 32 ARCH=m68k O=/kisskb/build/gustavoars_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 32 ARCH=m68k O=/kisskb/build/gustavoars_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 32 ARCH=m68k O=/kisskb/build/gustavoars_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- /kisskb/src/arch/m68k/mvme147/config.c: In function 'mvme147_hwclk': /kisskb/src/arch/m68k/mvme147/config.c:174:2: error: #warning check me! [-Werror=cpp] #warning check me! ^~~~~~~ /kisskb/src/arch/m68k/mvme16x/config.c: In function 'mvme16x_hwclk': /kisskb/src/arch/m68k/mvme16x/config.c:439:2: error: #warning check me! [-Werror=cpp] #warning check me! ^~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:277: arch/m68k/mvme147/config.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:540: arch/m68k/mvme147] Error 2 make[2]: *** Waiting for unfinished jobs.... cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:277: arch/m68k/mvme16x/config.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:540: arch/m68k/mvme16x] Error 2 make[1]: *** [/kisskb/src/Makefile:1882: arch/m68k] Error 2 make[1]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/arch/m68k/include/asm/io_mm.h:25, from /kisskb/src/arch/m68k/include/asm/io.h:8, from /kisskb/src/include/linux/io.h:13, from /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:12: /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write': /kisskb/src/arch/m68k/include/asm/raw_io.h:30:32: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] #define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:354:72: note: in expansion of macro 'out_8' #define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) ^~~~~ /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:20:2: note: in expansion of macro 'outb' outb((u8)data, (u16)(port + 0x378)); ^~~~ /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read': /kisskb/src/arch/m68k/include/asm/raw_io.h:20:19: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) ^ /kisskb/src/arch/m68k/include/asm/io_mm.h:347:56: note: in expansion of macro 'in_8' #define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) ^~~~ /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:26:9: note: in expansion of macro 'inb' data = inb((u16)(port + 0x378)); ^~~ cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/misc/altera-stapl/altera-lpt.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/misc/altera-stapl] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/misc] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/gpu/drm/rockchip/cdn-dp-core.c:1126:12: error: 'cdn_dp_resume' defined but not used [-Werror=unused-function] static int cdn_dp_resume(struct device *dev) ^~~~~~~~~~~~~ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/gpu/drm/rockchip/cdn-dp-core.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu/drm/rockchip] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu/drm] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:540: drivers/gpu] Error 2 make[1]: *** [/kisskb/src/Makefile:1882: drivers] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 32 ARCH=m68k O=/kisskb/build/gustavoars_m68k-allmodconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/gustavoars_m68k-allmodconfig_m68k-gcc8 # Build took: 0:03:40.530287