Buildresult: powerpc-fixes/pseries_defconfig+NO_MEMORY_HOTREMOVE/powerpc-gcc9 built on Oct 9 2021, 04:30

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Oct 9 2021, 04:30
Duration:	0:02:26.229872
Builder:	ka4
Revision:	pseries/eeh: Fix the kdump kernel crash during eeh_pseries_init (`eb8257a12192f43ffd41bd90932c39dade958042)`
Target:	powerpc-fixes/pseries_defconfig+NO_MEMORY_HOTREMOVE/powerpc-gcc9
Branch:	powerpc-fixes
Compiler:	powerpc-gcc9 (powerpc64-linux-gcc (GCC) 9.2.0 / GNU ld (GNU Binutils) 2.32)
Config:	pseries_defconfig+NO_MEMORY_HOTREMOVE (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify eb8257a12192f43ffd41bd90932c39dade958042^{commit} eb8257a12192f43ffd41bd90932c39dade958042 already have revision, skipping fetch # git checkout -q -f -B kisskb eb8257a12192f43ffd41bd90932c39dade958042 # git clean -qxdf # < git log -1 # commit eb8257a12192f43ffd41bd90932c39dade958042 # Author: Mahesh Salgaonkar <mahesh@linux.ibm.com> # Date: Mon Sep 20 22:03:26 2021 +0530 # # pseries/eeh: Fix the kdump kernel crash during eeh_pseries_init # # On pseries LPAR when an empty slot is assigned to partition OR in single # LPAR mode, kdump kernel crashes during issuing PHB reset. # # In the kdump scenario, we traverse all PHBs and issue reset using the # pe_config_addr of the first child device present under each PHB. However # the code assumes that none of the PHB slots can be empty and uses # list_first_entry() to get the first child device under the PHB. Since # list_first_entry() expects the list to be non-empty, it returns an # invalid pci_dn entry and ends up accessing NULL phb pointer under # pci_dn->phb causing kdump kernel crash. # # This patch fixes the below kdump kernel crash by skipping empty slots: # # audit: initializing netlink subsys (disabled) # thermal_sys: Registered thermal governor 'fair_share' # thermal_sys: Registered thermal governor 'step_wise' # cpuidle: using governor menu # pstore: Registered nvram as persistent store backend # Issue PHB reset ... # audit: type=2000 audit(1631267818.000:1): state=initialized audit_enabled=0 res=1 # BUG: Kernel NULL pointer dereference on read at 0x00000268 # Faulting instruction address: 0xc000000008101fb0 # Oops: Kernel access of bad area, sig: 7 [#1] # LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries # Modules linked in: # CPU: 7 PID: 1 Comm: swapper/7 Not tainted 5.14.0 #1 # NIP: c000000008101fb0 LR: c000000009284ccc CTR: c000000008029d70 # REGS: c00000001161b840 TRAP: 0300 Not tainted (5.14.0) # MSR: 8000000002009033 <SF,VEC,EE,ME,IR,DR,RI,LE> CR: 28000224 XER: 20040002 # CFAR: c000000008101f0c DAR: 0000000000000268 DSISR: 00080000 IRQMASK: 0 # ... # NIP pseries_eeh_get_pe_config_addr+0x100/0x1b0 # LR __machine_initcall_pseries_eeh_pseries_init+0x2cc/0x350 # Call Trace: # 0xc00000001161bb80 (unreliable) # __machine_initcall_pseries_eeh_pseries_init+0x2cc/0x350 # do_one_initcall+0x60/0x2d0 # kernel_init_freeable+0x350/0x3f8 # kernel_init+0x3c/0x17c # ret_from_kernel_thread+0x5c/0x64 # # Fixes: 5a090f7c363fd ("powerpc/pseries: PCIE PHB reset") # Signed-off-by: Mahesh Salgaonkar <mahesh@linux.ibm.com> # [mpe: Tweak wording and trim oops] # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # Link: https://lore.kernel.org/r/163215558252.413351.8600189949820258982.stgit@jupiter # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 eb8257a12192f43ffd41bd90932c39dade958042 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- pseries_defconfig # Added to kconfig CONFIG_MEMORY_HOTPLUG=y # Added to kconfig CONFIG_MEMORY_HOTREMOVE=n # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc9 # Build took: 0:02:26.229872

© Michael Ellerman 2006-2018.