# git rev-parse -q --verify 5c4e0a21fae877a7ef89be6dcc6263ec672372b8^{commit} 5c4e0a21fae877a7ef89be6dcc6263ec672372b8 already have revision, skipping fetch # git checkout -q -f -B kisskb 5c4e0a21fae877a7ef89be6dcc6263ec672372b8 # git clean -qxdf # < git log -1 # commit 5c4e0a21fae877a7ef89be6dcc6263ec672372b8 # Author: Guenter Roeck # Date: Tue Nov 2 07:24:20 2021 -0700 # # string: uninline memcpy_and_pad # # When building m68k:allmodconfig, recent versions of gcc generate the # following error if the length of UTS_RELEASE is less than 8 bytes. # # In function 'memcpy_and_pad', # inlined from 'nvmet_execute_disc_identify' at # drivers/nvme/target/discovery.c:268:2: arch/m68k/include/asm/string.h:72:25: error: # '__builtin_memcpy' reading 8 bytes from a region of size 7 # # Discussions around the problem suggest that this only happens if an # architecture does not provide strlen(), if -ffreestanding is provided as # compiler option, and if CONFIG_FORTIFY_SOURCE=n. All of this is the case # for m68k. The exact reasons are unknown, but seem to be related to the # ability of the compiler to evaluate the return value of strlen() and # the resulting execution flow in memcpy_and_pad(). It would be possible # to work around the problem by using sizeof(UTS_RELEASE) instead of # strlen(UTS_RELEASE), but that would only postpone the problem until the # function is called in a similar way. Uninline memcpy_and_pad() instead # to solve the problem for good. # # Suggested-by: Linus Torvalds # Reviewed-by: Geert Uytterhoeven # Acked-by: Andy Shevchenko # Signed-off-by: Guenter Roeck # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 5c4e0a21fae877a7ef89be6dcc6263ec672372b8 # < make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- x86_64_defconfig # < make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 # Build took: 0:01:34.161396