# git rev-parse -q --verify 4c388a8e740d3235a194f330c8ef327deef710f6^{commit} 4c388a8e740d3235a194f330c8ef327deef710f6 already have revision, skipping fetch # git checkout -q -f -B kisskb 4c388a8e740d3235a194f330c8ef327deef710f6 # git clean -qxdf # < git log -1 # commit 4c388a8e740d3235a194f330c8ef327deef710f6 # Merge: e26dd976580a 7416cdc9b9c1 # Author: Linus Torvalds # Date: Thu Nov 18 17:09:05 2021 -0800 # # Merge tag 'zstd-for-linus-5.16-rc1' of git://github.com/terrelln/linux # # Pull zstd fixes from Nick Terrell: # "Fix stack usage on parisc & improve code size bloat # # This contains three commits: # # 1. Fixes a minor unused variable warning reported by Kernel test # robot [0]. # # 2. Improves the reported code bloat (-88KB / 374KB) [1] by outlining # some functions that are unlikely to be used in performance # sensitive workloads. # # 3. Fixes the reported excess stack usage on parisc [2] by removing # -O3 from zstd's compilation flags. -O3 triggered bugs in the # hppa-linux-gnu gcc-8 compiler. -O2 performance is acceptable: # neutral compression, about -1% decompression speed. We also reduce # code bloat (-105KB / 374KB). # # After this our code bloat is cut from 374KB to 105KB with gcc-11. If # we wanted to cut the remaining 105KB we'd likely have to trade # signicant performance, so I want to say that this is enough for now. # # We should be able to get further gains without sacrificing speed, but # that will take some significant optimization effort, and isn't # suitable for a quick fix. I've opened an upstream issue [3] to track # the code size, and try to avoid future regressions, and improve it in # the long term" # # Link: https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/ [0] # Link: https://lkml.org/lkml/2021/11/15/710 [1] # Link: https://lkml.org/lkml/2021/11/14/189 [2] # Link: https://github.com/facebook/zstd/issues/2867 [3] # Link: https://lore.kernel.org/r/20211117014949.1169186-1-nickrterrell@gmail.com/ # Link: https://lore.kernel.org/r/20211117201459.1194876-1-nickrterrell@gmail.com/ # # * tag 'zstd-for-linus-5.16-rc1' of git://github.com/terrelln/linux: # lib: zstd: Don't add -O3 to cflags # lib: zstd: Don't inline functions in zstd_opt.c # lib: zstd: Fix unused variable warning # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 4c388a8e740d3235a194f330c8ef327deef710f6 # < make -s -j 8 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- allmodconfig # < make -s -j 8 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- help # make -s -j 8 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- olddefconfig # make -s -j 8 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- In file included from : /kisskb/src/drivers/pinctrl/pinctrl-apple-gpio.c: In function 'apple_gpio_irq_unmask': /kisskb/src/include/linux/compiler_types.h:335:38: error: call to '__compiletime_assert_366' declared with attribute error: FIELD_PREP: value too large for the field _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:316:4: note: in definition of macro '__compiletime_assert' prefix ## suffix(); \ ^~~~~~ /kisskb/src/include/linux/compiler_types.h:335:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^~~~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/bitfield.h:49:3: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \ ^~~~~~~~~~~~~~~~ /kisskb/src/include/linux/bitfield.h:94:3: note: in expansion of macro '__BF_FIELD_CHECK' __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \ ^~~~~~~~~~~~~~~~ /kisskb/src/drivers/pinctrl/pinctrl-apple-gpio.c:294:7: note: in expansion of macro 'FIELD_PREP' FIELD_PREP(REG_GPIOx_MODE, irqtype)); ^~~~~~~~~~ make[3]: *** [/kisskb/src/scripts/Makefile.build:287: drivers/pinctrl/pinctrl-apple-gpio.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:549: drivers/pinctrl] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1846: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 8 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_arm64-allmodconfig_arm64-gcc8 # Build took: 0:16:37.244976