# git rev-parse -q --verify 3dc709e518b47386e6af937eaec37bb36539edfd^{commit} 3dc709e518b47386e6af937eaec37bb36539edfd already have revision, skipping fetch # git checkout -q -f -B kisskb 3dc709e518b47386e6af937eaec37bb36539edfd # git clean -qxdf # < git log -1 # commit 3dc709e518b47386e6af937eaec37bb36539edfd # Author: Xiaoming Ni # Date: Fri Nov 26 12:11:53 2021 +0800 # # powerpc/85xx: Fix oops when CONFIG_FSL_PMC=n # # When CONFIG_FSL_PMC is set to n, no value is assigned to cpu_up_prepare # in the mpc85xx_pm_ops structure. As a result, oops is triggered in # smp_85xx_start_cpu(). # # smp: Bringing up secondary CPUs ... # kernel tried to execute user page (0) - exploit attempt? (uid: 0) # BUG: Unable to handle kernel instruction fetch (NULL pointer?) # Faulting instruction address: 0x00000000 # Oops: Kernel access of bad area, sig: 11 [#1] # ... # NIP [00000000] 0x0 # LR [c0021d2c] smp_85xx_kick_cpu+0xe8/0x568 # Call Trace: # [c1051da8] [c0021cb8] smp_85xx_kick_cpu+0x74/0x568 (unreliable) # [c1051de8] [c0011460] __cpu_up+0xc0/0x228 # [c1051e18] [c0031bbc] bringup_cpu+0x30/0x224 # [c1051e48] [c0031f3c] cpu_up.constprop.0+0x180/0x33c # [c1051e88] [c00322e8] bringup_nonboot_cpus+0x88/0xc8 # [c1051eb8] [c07e67bc] smp_init+0x30/0x78 # [c1051ed8] [c07d9e28] kernel_init_freeable+0x118/0x2a8 # [c1051f18] [c00032d8] kernel_init+0x14/0x124 # [c1051f38] [c0010278] ret_from_kernel_thread+0x14/0x1c # # Fixes: c45361abb918 ("powerpc/85xx: fix timebase sync issue when CONFIG_HOTPLUG_CPU=n") # Reported-by: Martin Kennedy # Signed-off-by: Xiaoming Ni # Tested-by: Martin Kennedy # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20211126041153.16926-1-nixiaoming@huawei.com # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 3dc709e518b47386e6af937eaec37bb36539edfd # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4297:warning: override: reassigning to symbol PPC_E500MC .config:4298:warning: override: reassigning to symbol VIRTUALIZATION # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- :1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp] In file included from /kisskb/src/include/linux/build_bug.h:5, from /kisskb/src/include/linux/container_of.h:5, from /kisskb/src/include/linux/list.h:5, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc9 # Build took: 0:02:51.318722