# git rev-parse -q --verify af11dee4361b3519981fa04d014873f9d9edd6ac^{commit} af11dee4361b3519981fa04d014873f9d9edd6ac already have revision, skipping fetch # git checkout -q -f -B kisskb af11dee4361b3519981fa04d014873f9d9edd6ac # git clean -qxdf # < git log -1 # commit af11dee4361b3519981fa04d014873f9d9edd6ac # Author: Christophe Leroy # Date: Tue Nov 30 09:42:37 2021 +0100 # # powerpc/32s: Fix shift-out-of-bounds in KASAN init # # ================================================================================ # UBSAN: shift-out-of-bounds in arch/powerpc/mm/kasan/book3s_32.c:22:23 # shift exponent -1 is negative # CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.5-gentoo-PowerMacG4 #9 # Call Trace: # [c214be60] [c0ba0048] dump_stack_lvl+0x80/0xb0 (unreliable) # [c214be80] [c0b99288] ubsan_epilogue+0x10/0x5c # [c214be90] [c0b98fe0] __ubsan_handle_shift_out_of_bounds+0x94/0x138 # [c214bf00] [c1c0f010] kasan_init_region+0xd8/0x26c # [c214bf30] [c1c0ed84] kasan_init+0xc0/0x198 # [c214bf70] [c1c08024] setup_arch+0x18/0x54c # [c214bfc0] [c1c037f0] start_kernel+0x90/0x33c # [c214bff0] [00003610] 0x3610 # ================================================================================ # # This happens when the directly mapped memory is a power of 2. # # Fix it by checking the shift and set the result to 0 when shift is -1 # # Fixes: 7974c4732642 ("powerpc/32s: Implement dedicated kasan_init_region()") # Reported-by: Erhard Furtner # Signed-off-by: Christophe Leroy # Signed-off-by: Michael Ellerman # Link: https://bugzilla.kernel.org/show_bug.cgi?id=215169 # Link: https://lore.kernel.org/r/15cbc3439d4ad988b225e2119ec99502a5cc6ad3.1638261744.git.christophe.leroy@csgroup.eu # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 af11dee4361b3519981fa04d014873f9d9edd6ac # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4298:warning: override: reassigning to symbol PPC_E500MC .config:4299:warning: override: reassigning to symbol VIRTUALIZATION # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- :1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp] In file included from /kisskb/src/include/linux/bitops.h:33, from /kisskb/src/include/linux/kernel.h:13, from /kisskb/src/include/linux/cpumask.h:10, from /kisskb/src/include/linux/smp.h:13, from /kisskb/src/include/linux/lockdep.h:14, from /kisskb/src/include/linux/mutex.h:17, from /kisskb/src/arch/powerpc/include/asm/kvm_ppc.h:15, from /kisskb/src/arch/powerpc/kvm/e500_emulate.c:12: /kisskb/src/arch/powerpc/include/asm/bitops.h: In function 'kvmppc_core_emulate_op_e500': /kisskb/src/arch/powerpc/include/asm/bitops.h:104:3: error: asm operand 2 probably doesn't match constraints [-Werror] 104 | asm volatile ( \ | ^~~ /kisskb/src/arch/powerpc/include/asm/bitops.h:126:1: note: in expansion of macro 'DEFINE_CLROP' 126 | DEFINE_CLROP(clear_bits, "") | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/include/asm/bitops.h:104:3: error: impossible constraint in 'asm' 104 | asm volatile ( \ | ^~~ /kisskb/src/arch/powerpc/include/asm/bitops.h:126:1: note: in expansion of macro 'DEFINE_CLROP' 126 | DEFINE_CLROP(clear_bits, "") | ^~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:287: arch/powerpc/kvm/e500_emulate.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:549: arch/powerpc/kvm] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1846: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc9 # Build took: 0:00:47.018908