# git rev-parse -q --verify 63045bfd3c8dbe9c8bee7e33291202725154cb2c^{commit} 63045bfd3c8dbe9c8bee7e33291202725154cb2c already have revision, skipping fetch # git checkout -q -f -B kisskb 63045bfd3c8dbe9c8bee7e33291202725154cb2c # git clean -qxdf # < git log -1 # commit 63045bfd3c8dbe9c8bee7e33291202725154cb2c # Author: Linus Torvalds # Date: Mon Jan 10 19:33:36 2022 -0800 # # netfilter: nf_tables: don't use 'data_size' uninitialized # # Commit 2c865a8a28a1 ("netfilter: nf_tables: add rule blob layout") never # initialized the new 'data_size' variable. # # I'm not sure how it ever worked, but it might have worked almost by # accident - gcc seems to occasionally miss these kinds of 'variable used # uninitialized' situations, but I've seen it do so because it ended up # zero-initializing them due to some other simplification. # # But clang is very unhappy about it all, and correctly reports # # net/netfilter/nf_tables_api.c:8278:4: error: variable 'data_size' is uninitialized when used here [-Werror,-Wuninitialized] # data_size += sizeof(*prule) + rule->dlen; # ^~~~~~~~~ # net/netfilter/nf_tables_api.c:8263:30: note: initialize the variable 'data_size' to silence this warning # unsigned int size, data_size; # ^ # = 0 # 1 error generated. # # and this fix just initializes 'data_size' to zero before the loop. # # Fixes: 2c865a8a28a1 ("netfilter: nf_tables: add rule blob layout") # Cc: Pablo Neira Ayuso # Cc: Jakub Kicinski # Cc: David Miller # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 63045bfd3c8dbe9c8bee7e33291202725154cb2c # < make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:7515:warning: override: reassigning to symbol MODULE_SIG .config:7518:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:7519:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:7520:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD .config:7522:warning: override: reassigning to symbol GCC_PLUGINS # make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.stubs' from `drivers/mfd/rsmu_core.o' being placed in section `.stubs' /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.stubs' from `drivers/mfd/rsmu_core.o' being placed in section `.stubs' /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.stubs' from `drivers/mfd/rsmu_core.o' being placed in section `.stubs' Completed OK # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 # Build took: 0:05:27.105526