# git rev-parse -q --verify c36c04c2e132fc39f6b658bf607aed4425427fd7^{commit}
c36c04c2e132fc39f6b658bf607aed4425427fd7
already have revision, skipping fetch
# git checkout -q -f -B kisskb c36c04c2e132fc39f6b658bf607aed4425427fd7
# git clean -qxdf
# < git log -1
# commit c36c04c2e132fc39f6b658bf607aed4425427fd7
# Author: John Hubbard <jhubbard@nvidia.com>
# Date:   Tue Feb 1 19:23:17 2022 -0800
# 
#     Revert "mm/gup: small refactoring: simplify try_grab_page()"
#     
#     This reverts commit 54d516b1d62ff8f17cee2da06e5e4706a0d00b8a
#     
#     That commit did a refactoring that effectively combined fast and slow
#     gup paths (again).  And that was again incorrect, for two reasons:
#     
#      a) Fast gup and slow gup get reference counts on pages in different
#         ways and with different goals: see Linus' writeup in commit
#         cd1adf1b63a1 ("Revert "mm/gup: remove try_get_page(), call
#         try_get_compound_head() directly""), and
#     
#      b) try_grab_compound_head() also has a specific check for
#         "FOLL_LONGTERM && !is_pinned(page)", that assumes that the caller
#         can fall back to slow gup. This resulted in new failures, as
#         recently report by Will McVicker [1].
#     
#     But (a) has problems too, even though they may not have been reported
#     yet.  So just revert this.
#     
#     Link: https://lore.kernel.org/r/20220131203504.3458775-1-willmcvicker@google.com [1]
#     Fixes: 54d516b1d62f ("mm/gup: small refactoring: simplify try_grab_page()")
#     Reported-and-tested-by: Will McVicker <willmcvicker@google.com>
#     Cc: Christoph Hellwig <hch@lst.de>
#     Cc: Minchan Kim <minchan@google.com>
#     Cc: Matthew Wilcox <willy@infradead.org>
#     Cc: Christian Borntraeger <borntraeger@de.ibm.com>
#     Cc: Heiko Carstens <hca@linux.ibm.com>
#     Cc: Vasily Gorbik <gor@linux.ibm.com>
#     Cc: stable@vger.kernel.org # 5.15
#     Signed-off-by: John Hubbard <jhubbard@nvidia.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version
# < git log --format=%s --max-count=1 c36c04c2e132fc39f6b658bf607aed4425427fd7
# < make -s -j 32 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  allmodconfig
# Added to kconfig CONFIG_64BIT=n
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n
# Added to kconfig CONFIG_SAMPLES=n
# Added to kconfig CONFIG_MODULE_SIG=n
# < make -s -j 32 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  help
# make -s -j 32 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  olddefconfig
# make -s -j 32 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  
<stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_page_for_dma':
/kisskb/src/arch/sparc/mm/srmmu.c:1639:13: error: cast between incompatible function types from 'void (*)(long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1639 |         xc1((smpfunc_t) local_ops->page_for_dma, page);
      |             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_cache_mm':
/kisskb/src/arch/sparc/mm/srmmu.c:1662:29: error: cast between incompatible function types from 'void (*)(struct mm_struct *)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1662 |                         xc1((smpfunc_t) local_ops->cache_mm, (unsigned long) mm);
      |                             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_tlb_mm':
/kisskb/src/arch/sparc/mm/srmmu.c:1674:29: error: cast between incompatible function types from 'void (*)(struct mm_struct *)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1674 |                         xc1((smpfunc_t) local_ops->tlb_mm, (unsigned long) mm);
      |                             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_cache_range':
/kisskb/src/arch/sparc/mm/srmmu.c:1694:29: error: cast between incompatible function types from 'void (*)(struct vm_area_struct *, long unsigned int,  long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1694 |                         xc3((smpfunc_t) local_ops->cache_range,
      |                             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_tlb_range':
/kisskb/src/arch/sparc/mm/srmmu.c:1711:29: error: cast between incompatible function types from 'void (*)(struct vm_area_struct *, long unsigned int,  long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1711 |                         xc3((smpfunc_t) local_ops->tlb_range,
      |                             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_cache_page':
/kisskb/src/arch/sparc/mm/srmmu.c:1726:29: error: cast between incompatible function types from 'void (*)(struct vm_area_struct *, long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1726 |                         xc2((smpfunc_t) local_ops->cache_page,
      |                             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_tlb_page':
/kisskb/src/arch/sparc/mm/srmmu.c:1741:29: error: cast between incompatible function types from 'void (*)(struct vm_area_struct *, long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1741 |                         xc2((smpfunc_t) local_ops->tlb_page,
      |                             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_page_to_ram':
/kisskb/src/arch/sparc/mm/srmmu.c:1756:13: error: cast between incompatible function types from 'void (*)(long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1756 |         xc1((smpfunc_t) local_ops->page_to_ram, page);
      |             ^
/kisskb/src/arch/sparc/mm/srmmu.c: In function 'smp_flush_sig_insns':
/kisskb/src/arch/sparc/mm/srmmu.c:1767:21: error: cast between incompatible function types from 'void (*)(struct mm_struct *, long unsigned int)' to 'void (*)(long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int,  long unsigned int)' [-Werror=cast-function-type]
 1767 |                 xc2((smpfunc_t) local_ops->sig_insns,
      |                     ^
cc1: all warnings being treated as errors
make[3]: *** [/kisskb/src/scripts/Makefile.build:288: arch/sparc/mm/srmmu.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/kisskb/src/scripts/Makefile.build:550: arch/sparc/mm] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/kisskb/src/Makefile:1831: arch/sparc] Error 2
make[1]: *** Waiting for unfinished jobs....
/kisskb/src/crypto/blake2b_generic.c: In function 'blake2b_compress_one_generic':
/kisskb/src/crypto/blake2b_generic.c:109:1: error: the frame size of 2288 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
  109 | }
      | ^
cc1: all warnings being treated as errors
make[2]: *** [/kisskb/src/scripts/Makefile.build:288: crypto/blake2b_generic.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/kisskb/src/Makefile:1831: crypto] Error 2
make: *** [Makefile:219: __sub-make] Error 2
Command 'make -s -j 32 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  ' returned non-zero exit status 2
# rm -rf /kisskb/build/linus_sparc-allmodconfig_sparc64-gcc11
# Build took: 0:14:15.766194