# git rev-parse -q --verify c36c04c2e132fc39f6b658bf607aed4425427fd7^{commit}
c36c04c2e132fc39f6b658bf607aed4425427fd7
already have revision, skipping fetch
# git checkout -q -f -B kisskb c36c04c2e132fc39f6b658bf607aed4425427fd7
# git clean -qxdf
# < git log -1
# commit c36c04c2e132fc39f6b658bf607aed4425427fd7
# Author: John Hubbard <jhubbard@nvidia.com>
# Date:   Tue Feb 1 19:23:17 2022 -0800
# 
#     Revert "mm/gup: small refactoring: simplify try_grab_page()"
#     
#     This reverts commit 54d516b1d62ff8f17cee2da06e5e4706a0d00b8a
#     
#     That commit did a refactoring that effectively combined fast and slow
#     gup paths (again).  And that was again incorrect, for two reasons:
#     
#      a) Fast gup and slow gup get reference counts on pages in different
#         ways and with different goals: see Linus' writeup in commit
#         cd1adf1b63a1 ("Revert "mm/gup: remove try_get_page(), call
#         try_get_compound_head() directly""), and
#     
#      b) try_grab_compound_head() also has a specific check for
#         "FOLL_LONGTERM && !is_pinned(page)", that assumes that the caller
#         can fall back to slow gup. This resulted in new failures, as
#         recently report by Will McVicker [1].
#     
#     But (a) has problems too, even though they may not have been reported
#     yet.  So just revert this.
#     
#     Link: https://lore.kernel.org/r/20220131203504.3458775-1-willmcvicker@google.com [1]
#     Fixes: 54d516b1d62f ("mm/gup: small refactoring: simplify try_grab_page()")
#     Reported-and-tested-by: Will McVicker <willmcvicker@google.com>
#     Cc: Christoph Hellwig <hch@lst.de>
#     Cc: Minchan Kim <minchan@google.com>
#     Cc: Matthew Wilcox <willy@infradead.org>
#     Cc: Christian Borntraeger <borntraeger@de.ibm.com>
#     Cc: Heiko Carstens <hca@linux.ibm.com>
#     Cc: Vasily Gorbik <gor@linux.ibm.com>
#     Cc: stable@vger.kernel.org # 5.15
#     Signed-off-by: John Hubbard <jhubbard@nvidia.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 c36c04c2e132fc39f6b658bf607aed4425427fd7
# < make -s -j 48 ARCH=sh O=/kisskb/build/linus_se7619_defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  se7619_defconfig
# < make -s -j 48 ARCH=sh O=/kisskb/build/linus_se7619_defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  help
# make -s -j 48 ARCH=sh O=/kisskb/build/linus_se7619_defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  olddefconfig
# make -s -j 48 ARCH=sh O=/kisskb/build/linus_se7619_defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
In file included from /kisskb/src/arch/sh/include/asm/hw_irq.h:6,
                 from /kisskb/src/include/linux/irq.h:594,
                 from /kisskb/src/include/asm-generic/hardirq.h:17,
                 from /kisskb/src/arch/sh/include/asm/hardirq.h:9,
                 from /kisskb/src/include/linux/hardirq.h:11,
                 from /kisskb/src/include/linux/interrupt.h:11,
                 from /kisskb/src/include/linux/serial_core.h:13,
                 from /kisskb/src/include/linux/serial_sci.h:6,
                 from /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:11:
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:105:24: note: in expansion of macro '_INTC_ARRAY'
  105 |  _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \
      |                        ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:106:2: note: in expansion of macro '_INTC_ARRAY'
  106 |  _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \
      |  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:2: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:27: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |                           ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_remap_port':
/kisskb/src/drivers/tty/serial/sh-sci.c:2651:19: warning: unused variable 'sport' [-Wunused-variable]
 2651 |  struct sci_port *sport = to_sci_port(port);
      |                   ^~~~~
Completed OK
# rm -rf /kisskb/build/linus_se7619_defconfig_sh4-gcc10
# Build took: 0:00:28.680122