Buildresult: linus-rand/powerpc-randconfig/powerpc-gcc9 built on Feb 4 2022, 04:46

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Feb 4 2022, 04:46
Duration:	0:02:43.738249
Builder:	blade4b
Revision:	Revert "mm/gup: small refactoring: simplify try_grab_page()" (`c36c04c2e132fc39f6b658bf607aed4425427fd7)`
Target:	linus-rand/powerpc-randconfig/powerpc-gcc9
Branch:	linus-rand
Compiler:	powerpc-gcc9 (powerpc64-linux-gcc (GCC) 9.2.0 / GNU ld (GNU Binutils) 2.32)
Config:	randconfig (download)
Log:	Download original Possible warnings (6) .config:3083:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:3084:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:3085:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD .config:3088:warning: override: reassigning to symbol LD_HEAD_STUB_CATCH .config:3089:warning: override: reassigning to symbol TRIM_UNUSED_KSYMS .config:3090:warning: override: reassigning to symbol UBSAN Full Log # git rev-parse -q --verify c36c04c2e132fc39f6b658bf607aed4425427fd7^{commit} c36c04c2e132fc39f6b658bf607aed4425427fd7 already have revision, skipping fetch # git checkout -q -f -B kisskb c36c04c2e132fc39f6b658bf607aed4425427fd7 # git clean -qxdf # < git log -1 # commit c36c04c2e132fc39f6b658bf607aed4425427fd7 # Author: John Hubbard <jhubbard@nvidia.com> # Date: Tue Feb 1 19:23:17 2022 -0800 # # Revert "mm/gup: small refactoring: simplify try_grab_page()" # # This reverts commit 54d516b1d62ff8f17cee2da06e5e4706a0d00b8a # # That commit did a refactoring that effectively combined fast and slow # gup paths (again). And that was again incorrect, for two reasons: # # a) Fast gup and slow gup get reference counts on pages in different # ways and with different goals: see Linus' writeup in commit # cd1adf1b63a1 ("Revert "mm/gup: remove try_get_page(), call # try_get_compound_head() directly""), and # # b) try_grab_compound_head() also has a specific check for # "FOLL_LONGTERM && !is_pinned(page)", that assumes that the caller # can fall back to slow gup. This resulted in new failures, as # recently report by Will McVicker [1]. # # But (a) has problems too, even though they may not have been reported # yet. So just revert this. # # Link: https://lore.kernel.org/r/20220131203504.3458775-1-willmcvicker@google.com [1] # Fixes: 54d516b1d62f ("mm/gup: small refactoring: simplify try_grab_page()") # Reported-and-tested-by: Will McVicker <willmcvicker@google.com> # Cc: Christoph Hellwig <hch@lst.de> # Cc: Minchan Kim <minchan@google.com> # Cc: Matthew Wilcox <willy@infradead.org> # Cc: Christian Borntraeger <borntraeger@de.ibm.com> # Cc: Heiko Carstens <hca@linux.ibm.com> # Cc: Vasily Gorbik <gor@linux.ibm.com> # Cc: stable@vger.kernel.org # 5.15 # Signed-off-by: John Hubbard <jhubbard@nvidia.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 c36c04c2e132fc39f6b658bf607aed4425427fd7 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:3083:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:3084:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:3085:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD .config:3088:warning: override: reassigning to symbol LD_HEAD_STUB_CATCH .config:3089:warning: override: reassigning to symbol TRIM_UNUSED_KSYMS .config:3090:warning: override: reassigning to symbol UBSAN # make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 # Build took: 0:02:43.738249

© Michael Ellerman 2006-2018.