# git rev-parse -q --verify c36c04c2e132fc39f6b658bf607aed4425427fd7^{commit} c36c04c2e132fc39f6b658bf607aed4425427fd7 already have revision, skipping fetch # git checkout -q -f -B kisskb c36c04c2e132fc39f6b658bf607aed4425427fd7 # git clean -qxdf # < git log -1 # commit c36c04c2e132fc39f6b658bf607aed4425427fd7 # Author: John Hubbard # Date: Tue Feb 1 19:23:17 2022 -0800 # # Revert "mm/gup: small refactoring: simplify try_grab_page()" # # This reverts commit 54d516b1d62ff8f17cee2da06e5e4706a0d00b8a # # That commit did a refactoring that effectively combined fast and slow # gup paths (again). And that was again incorrect, for two reasons: # # a) Fast gup and slow gup get reference counts on pages in different # ways and with different goals: see Linus' writeup in commit # cd1adf1b63a1 ("Revert "mm/gup: remove try_get_page(), call # try_get_compound_head() directly""), and # # b) try_grab_compound_head() also has a specific check for # "FOLL_LONGTERM && !is_pinned(page)", that assumes that the caller # can fall back to slow gup. This resulted in new failures, as # recently report by Will McVicker [1]. # # But (a) has problems too, even though they may not have been reported # yet. So just revert this. # # Link: https://lore.kernel.org/r/20220131203504.3458775-1-willmcvicker@google.com [1] # Fixes: 54d516b1d62f ("mm/gup: small refactoring: simplify try_grab_page()") # Reported-and-tested-by: Will McVicker # Cc: Christoph Hellwig # Cc: Minchan Kim # Cc: Matthew Wilcox # Cc: Christian Borntraeger # Cc: Heiko Carstens # Cc: Vasily Gorbik # Cc: stable@vger.kernel.org # 5.15 # Signed-off-by: John Hubbard # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 c36c04c2e132fc39f6b658bf607aed4425427fd7 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:5332:warning: override: reassigning to symbol STANDALONE .config:5336:warning: override: reassigning to symbol PPC64 .config:5338:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:5339:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD .config:5341:warning: override: reassigning to symbol GCC_PLUGINS .config:5344:warning: override: reassigning to symbol UBSAN # make -s -j 32 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/mm/slice.c: In function 'slice_get_unmapped_area': /kisskb/src/arch/powerpc/mm/slice.c:639:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 639 | } | ^ /kisskb/src/fs/fat/dir.c: In function 'fat_add_new_entries': /kisskb/src/fs/fat/dir.c:1279:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1279 | } | ^ /kisskb/src/fs/fat/dir.c: In function 'fat_alloc_new_dir': /kisskb/src/fs/fat/dir.c:1195:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1195 | } | ^ /kisskb/src/fs/fat/fatent.c: In function 'fat_free_clusters': /kisskb/src/fs/fat/fatent.c:633:1: warning: the frame size of 1104 bytes is larger than 1024 bytes [-Wframe-larger-than=] 633 | } | ^ /kisskb/src/fs/fat/fatent.c: In function 'fat_alloc_clusters': /kisskb/src/fs/fat/fatent.c:551:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] 551 | } | ^ /kisskb/src/fs/ntfs/aops.c: In function 'ntfs_read_block': /kisskb/src/fs/ntfs/aops.c:358:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=] 358 | } | ^ /kisskb/src/fs/ext4/readpage.c: In function 'ext4_mpage_readpages': /kisskb/src/fs/ext4/readpage.c:407:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=] 407 | } | ^ /kisskb/src/fs/ntfs3/fsntfs.c: In function 'ntfs_clear_mft_tail': /kisskb/src/fs/ntfs3/fsntfs.c:772:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 772 | } | ^ /kisskb/src/fs/mpage.c: In function '__mpage_writepage': /kisskb/src/fs/mpage.c:665:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] 665 | } | ^ /kisskb/src/fs/mpage.c: In function 'do_mpage_readpage': /kisskb/src/fs/mpage.c:329:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 329 | } | ^ Completed OK # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc11 # Build took: 0:05:39.145432