# git rev-parse -q --verify fe663df7825811358531dc2e8a52d9eaa5e3515e^{commit} fe663df7825811358531dc2e8a52d9eaa5e3515e already have revision, skipping fetch # git checkout -q -f -B kisskb fe663df7825811358531dc2e8a52d9eaa5e3515e # git clean -qxdf # < git log -1 # commit fe663df7825811358531dc2e8a52d9eaa5e3515e # Author: Anders Roxell # Date: Fri Feb 11 01:51:13 2022 +0100 # # powerpc/lib/sstep: fix 'ptesync' build error # # Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian # 2.37.90.20220207) the following build error shows up: # # {standard input}: Assembler messages: # {standard input}:2088: Error: unrecognized opcode: `ptesync' # make[3]: *** [/builds/linux/scripts/Makefile.build:287: arch/powerpc/lib/sstep.o] Error 1 # # Add the 'ifdef CONFIG_PPC64' around the 'ptesync' in function # 'emulate_update_regs()' to like it is in 'analyse_instr()'. Since it looks like # it got dropped inadvertently by commit 3cdfcbfd32b9 ("powerpc: Change # analyse_instr so it doesn't modify *regs"). # # A key detail is that analyse_instr() will never recognise lwsync or # ptesync on 32-bit (because of the existing ifdef), and as a result # emulate_update_regs() should never be called with an op specifying # either of those on 32-bit. So removing them from emulate_update_regs() # should be a nop in terms of runtime behaviour. # # Fixes: 3cdfcbfd32b9 ("powerpc: Change analyse_instr so it doesn't modify *regs") # Cc: stable@vger.kernel.org # v4.14+ # Suggested-by: Arnd Bergmann # Signed-off-by: Anders Roxell # [mpe: Add last paragraph of change log mentioning analyse_instr() details] # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20220211005113.1361436-1-anders.roxell@linaro.org # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 fe663df7825811358531dc2e8a52d9eaa5e3515e # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/build_bug.h:5:0, from /kisskb/src/include/linux/container_of.h:5, from /kisskb/src/include/linux/list.h:5, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 # Build took: 0:02:43.747593