# git rev-parse -q --verify 48015b632f770c401f3816f144499a39f2884677^{commit} 48015b632f770c401f3816f144499a39f2884677 already have revision, skipping fetch # git checkout -q -f -B kisskb 48015b632f770c401f3816f144499a39f2884677 # git clean -qxdf # < git log -1 # commit 48015b632f770c401f3816f144499a39f2884677 # Author: Michael Ellerman # Date: Fri Feb 11 17:32:37 2022 +1100 # # powerpc: Fix STACKTRACE=n build # # Our skiroot_defconfig doesn't enable FTRACE, and so doesn't get # STACKTRACE enabled either. That leads to a build failure since commit # 1614b2b11fab ("arch: Make ARCH_STACKWALK independent of STACKTRACE") # made stacktrace.c build even when STACKTRACE=n. # # arch/powerpc/kernel/stacktrace.c: In function ‘handle_backtrace_ipi’: # arch/powerpc/kernel/stacktrace.c:171:2: error: implicit declaration of function ‘nmi_cpu_backtrace’ # 171 | nmi_cpu_backtrace(regs); # | ^~~~~~~~~~~~~~~~~ # arch/powerpc/kernel/stacktrace.c: In function ‘arch_trigger_cpumask_backtrace’: # arch/powerpc/kernel/stacktrace.c:226:2: error: implicit declaration of function ‘nmi_trigger_cpumask_backtrace’ # 226 | nmi_trigger_cpumask_backtrace(mask, exclude_self, raise_backtrace_ipi); # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # # This happens because our headers haven't defined # arch_trigger_cpumask_backtrace, which causes lib/nmi_backtrace.c not to # build nmi_cpu_backtrace(). # # The code in question doesn't actually depend on STACKTRACE=y, that was # just added because arch_trigger_cpumask_backtrace() lived in # stacktrace.c for convenience. So drop the dependency on # CONFIG_STACKTRACE, that causes lib/nmi_backtrace.c to build # nmi_cpu_backtrace() etc. and fixes the build. # # Fixes: 1614b2b11fab ("arch: Make ARCH_STACKWALK independent of STACKTRACE") # [mpe: Cherry pick of 5a72345e6a78 from next into fixes] # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20220212111349.2806972-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 48015b632f770c401f3816f144499a39f2884677 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_acadia_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- 40x/acadia_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_acadia_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_acadia_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_acadia_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/powerpc-fixes_40x_acadia_defconfig_powerpc-gcc5 # Build took: 0:00:54.168891