# git rev-parse -q --verify fe673d3f5bf1fc50cdc4b754831db91a2ec10126^{commit} fe673d3f5bf1fc50cdc4b754831db91a2ec10126 already have revision, skipping fetch # git checkout -q -f -B kisskb fe673d3f5bf1fc50cdc4b754831db91a2ec10126 # git clean -qxdf # < git log -1 # commit fe673d3f5bf1fc50cdc4b754831db91a2ec10126 # Author: Linus Torvalds # Date: Tue Mar 8 11:55:48 2022 -0800 # # mm: gup: make fault_in_safe_writeable() use fixup_user_fault() # # Instead of using GUP, make fault_in_safe_writeable() actually force a # 'handle_mm_fault()' using the same fixup_user_fault() machinery that # futexes already use. # # Using the GUP machinery meant that fault_in_safe_writeable() did not do # everything that a real fault would do, ranging from not auto-expanding # the stack segment, to not updating accessed or dirty flags in the page # tables (GUP sets those flags on the pages themselves). # # The latter causes problems on architectures (like s390) that do accessed # bit handling in software, which meant that fault_in_safe_writeable() # didn't actually do all the fault handling it needed to, and trying to # access the user address afterwards would still cause faults. # # Reported-and-tested-by: Andreas Gruenbacher # Fixes: cdd591fc86e3 ("iov_iter: Introduce fault_in_iov_iter_writeable") # Link: https://lore.kernel.org/all/CAHc6FU5nP+nziNGG0JAF1FUx-GV7kKFvM7aZuU_XD2_1v4vnvg@mail.gmail.com/ # Acked-by: David Hildenbrand # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 fe673d3f5bf1fc50cdc4b754831db91a2ec10126 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- skiroot_defconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/kernel/stacktrace.c: In function 'handle_backtrace_ipi': /kisskb/src/arch/powerpc/kernel/stacktrace.c:171:2: error: implicit declaration of function 'nmi_cpu_backtrace' [-Werror=implicit-function-declaration] nmi_cpu_backtrace(regs); ^ /kisskb/src/arch/powerpc/kernel/stacktrace.c: In function 'arch_trigger_cpumask_backtrace': /kisskb/src/arch/powerpc/kernel/stacktrace.c:226:2: error: implicit declaration of function 'nmi_trigger_cpumask_backtrace' [-Werror=implicit-function-declaration] nmi_trigger_cpumask_backtrace(mask, exclude_self, raise_backtrace_ipi); ^ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:288: arch/powerpc/kernel/stacktrace.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:550: arch/powerpc/kernel] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1831: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 # Build took: 0:01:39.932481