# git rev-parse -q --verify d888c83fcec75194a8a48ccd283953bdba7b2550^{commit} d888c83fcec75194a8a48ccd283953bdba7b2550 already have revision, skipping fetch # git checkout -q -f -B kisskb d888c83fcec75194a8a48ccd283953bdba7b2550 # git clean -qxdf # < git log -1 # commit d888c83fcec75194a8a48ccd283953bdba7b2550 # Author: Linus Torvalds # Date: Tue Mar 29 23:29:18 2022 -0700 # # fs: fix fd table size alignment properly # # Jason Donenfeld reports that my commit 1c24a186398f ("fs: fd tables have # to be multiples of BITS_PER_LONG") doesn't work, and the reason is an # embarrassing brown-paper-bag bug. # # Yes, we want to align the number of fds to BITS_PER_LONG, and yes, the # reason they might not be aligned is because the incoming 'max_fd' # argument might not be aligned. # # But aligining the argument - while simple - will cause a "infinitely # big" maxfd (eg NR_OPEN_MAX) to just overflow to zero. Which most # definitely isn't what we want either. # # The obvious fix was always just to do the alignment last, but I had # moved it earlier just to make the patch smaller and the code look # simpler. Duh. It certainly made _me_ look simple. # # Fixes: 1c24a186398f ("fs: fd tables have to be multiples of BITS_PER_LONG") # Reported-and-tested-by: Jason A. Donenfeld # Cc: Fedor Pchelkin # Cc: Alexey Khoroshilov # Cc: Christian Brauner # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 d888c83fcec75194a8a48ccd283953bdba7b2550 # < make -s -j 24 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux- randconfig # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # < make -s -j 24 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux- help # make -s -j 24 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux- olddefconfig # make -s -j 24 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux- In file included from /kisskb/src/include/linux/mtd/spi-nor.h:10, from /kisskb/src/drivers/spi/spi-intel.c:13: /kisskb/src/include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp] 62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. | ^~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:289: drivers/spi/spi-intel.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:551: drivers/spi] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1830: drivers] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 24 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_arm64-randconfig_arm64-gcc11 # Build took: 0:05:11.014881