# git rev-parse -q --verify d888c83fcec75194a8a48ccd283953bdba7b2550^{commit} d888c83fcec75194a8a48ccd283953bdba7b2550 already have revision, skipping fetch # git checkout -q -f -B kisskb d888c83fcec75194a8a48ccd283953bdba7b2550 # git clean -qxdf # < git log -1 # commit d888c83fcec75194a8a48ccd283953bdba7b2550 # Author: Linus Torvalds # Date: Tue Mar 29 23:29:18 2022 -0700 # # fs: fix fd table size alignment properly # # Jason Donenfeld reports that my commit 1c24a186398f ("fs: fd tables have # to be multiples of BITS_PER_LONG") doesn't work, and the reason is an # embarrassing brown-paper-bag bug. # # Yes, we want to align the number of fds to BITS_PER_LONG, and yes, the # reason they might not be aligned is because the incoming 'max_fd' # argument might not be aligned. # # But aligining the argument - while simple - will cause a "infinitely # big" maxfd (eg NR_OPEN_MAX) to just overflow to zero. Which most # definitely isn't what we want either. # # The obvious fix was always just to do the alignment last, but I had # moved it earlier just to make the patch smaller and the code look # simpler. Duh. It certainly made _me_ look simple. # # Fixes: 1c24a186398f ("fs: fd tables have to be multiples of BITS_PER_LONG") # Reported-and-tested-by: Jason A. Donenfeld # Cc: Fedor Pchelkin # Cc: Alexey Khoroshilov # Cc: Christian Brauner # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 d888c83fcec75194a8a48ccd283953bdba7b2550 # < make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allnoconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- allnoconfig # < make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allnoconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- help # make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allnoconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- olddefconfig # make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allnoconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Assembler messages: /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:16: Error: bad or irreducible absolute expression /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:16: Error: junk at end of line, first unrecognized character is `:' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:26: Error: no such instruction: `ldw 0(%sp),%r31' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:29: Error: no such instruction: `be 0x100(%sr2,%r0)' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:30: Error: no such instruction: `ldi 0,%r20' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:32: Error: .cfi_endproc without corresponding .cfi_startproc /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Assembler messages: /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:39: Error: unknown pseudo-op: `.proc' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:40: Error: unknown pseudo-op: `.callinfo' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:41: Error: unknown pseudo-op: `.entry' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:44: Error: no such instruction: `ldi 0,%r25' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:45: Error: no such instruction: `ldi 173,%r20' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:46: Error: no such instruction: `ble 0x100(%sr2,%r0)' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:49: Error: no such instruction: `ldi 1,%r25' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:50: Error: no such instruction: `ldi 173,%r20' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:51: Error: no such instruction: `ble 0x100(%sr2,%r0)' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:54: Error: unknown pseudo-op: `.exit' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:55: Error: unknown pseudo-op: `.procend' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:76: Error: unknown pseudo-op: `.stringz' make[2]: *** [/kisskb/src/arch/parisc/kernel/vdso32/Makefile:34: arch/parisc/kernel/vdso32/restart_syscall.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/arch/parisc/kernel/vdso32/Makefile:34: arch/parisc/kernel/vdso32/sigtramp.o] Error 1 make[1]: *** [/kisskb/src/arch/parisc/Makefile:177: vdso_prepare] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allnoconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_parisc-allnoconfig_parisc-gcc8 # Build took: 0:00:06.244968