# git rev-parse -q --verify 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9^{commit} 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 already have revision, skipping fetch # git checkout -q -f -B kisskb 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 # git clean -qxdf # < git log -1 # commit 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 # Author: Mario Limonciello # Date: Fri Apr 22 08:14:52 2022 -0500 # # gpio: Request interrupts after IRQ is initialized # # Commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members # before initialization") attempted to fix a race condition that lead to a # NULL pointer, but in the process caused a regression for _AEI/_EVT # declared GPIOs. # # This manifests in messages showing deferred probing while trying to # allocate IRQs like so: # # amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x0000 to IRQ, err -517 # amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x002C to IRQ, err -517 # amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517 # [ .. more of the same .. ] # # The code for walking _AEI doesn't handle deferred probing and so this # leads to non-functional GPIO interrupts. # # Fix this issue by moving the call to `acpi_gpiochip_request_interrupts` # to occur after gc->irc.initialized is set. # # Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization") # Link: https://lore.kernel.org/linux-gpio/BL1PR12MB51577A77F000A008AA694675E2EF9@BL1PR12MB5157.namprd12.prod.outlook.com/ # Link: https://bugzilla.suse.com/show_bug.cgi?id=1198697 # Link: https://bugzilla.kernel.org/show_bug.cgi?id=215850 # Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1979 # Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1976 # Reported-by: Mario Limonciello # Signed-off-by: Mario Limonciello # Reviewed-by: Shreeya Patel # Tested-By: Samuel Čavoj # Tested-By: lukeluk498@gmail.com Link: # Reviewed-by: Andy Shevchenko # Acked-by: Linus Walleij # Reviewed-and-tested-by: Takashi Iwai # Cc: Shreeya Patel # Cc: stable@vger.kernel.org # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 # < make -s -j 120 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- sun3_defconfig # < make -s -j 120 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 120 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 120 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- In file included from /kisskb/src/include/linux/swab.h:5, from /kisskb/src/include/uapi/linux/byteorder/big_endian.h:14, from /kisskb/src/include/linux/byteorder/big_endian.h:5, from /kisskb/src/arch/m68k/include/uapi/asm/byteorder.h:5, from /kisskb/src/include/asm-generic/bitops/le.h:6, from /kisskb/src/arch/m68k/include/asm/bitops.h:529, from /kisskb/src/include/linux/bitops.h:33, from /kisskb/src/include/linux/kernel.h:22, from /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:31: /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:989:108: warning: array subscript 1 is above array bounds of 'volatile struct transmit_cmd_struct *[1]' [-Warray-bounds] printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); ~~~~~~~~~~~~^~~ /kisskb/src/include/uapi/linux/swab.h:107:12: note: in definition of macro '__swab16' __fswab16(x)) ^ /kisskb/src/include/linux/printk.h:446:26: note: in expansion of macro 'printk_index_wrap' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:989:3: note: in expansion of macro 'printk' printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); ^~~~~~ Completed OK # rm -rf /kisskb/build/linus_sun3_defconfig_m68k-gcc8 # Build took: 0:00:38.278769