# git rev-parse -q --verify 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9^{commit} 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 already have revision, skipping fetch # git checkout -q -f -B kisskb 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 # git clean -qxdf # < git log -1 # commit 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 # Author: Mario Limonciello # Date: Fri Apr 22 08:14:52 2022 -0500 # # gpio: Request interrupts after IRQ is initialized # # Commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members # before initialization") attempted to fix a race condition that lead to a # NULL pointer, but in the process caused a regression for _AEI/_EVT # declared GPIOs. # # This manifests in messages showing deferred probing while trying to # allocate IRQs like so: # # amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x0000 to IRQ, err -517 # amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x002C to IRQ, err -517 # amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517 # [ .. more of the same .. ] # # The code for walking _AEI doesn't handle deferred probing and so this # leads to non-functional GPIO interrupts. # # Fix this issue by moving the call to `acpi_gpiochip_request_interrupts` # to occur after gc->irc.initialized is set. # # Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization") # Link: https://lore.kernel.org/linux-gpio/BL1PR12MB51577A77F000A008AA694675E2EF9@BL1PR12MB5157.namprd12.prod.outlook.com/ # Link: https://bugzilla.suse.com/show_bug.cgi?id=1198697 # Link: https://bugzilla.kernel.org/show_bug.cgi?id=215850 # Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1979 # Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1976 # Reported-by: Mario Limonciello # Signed-off-by: Mario Limonciello # Reviewed-by: Shreeya Patel # Tested-By: Samuel Čavoj # Tested-By: lukeluk498@gmail.com Link: # Reviewed-by: Andy Shevchenko # Acked-by: Linus Walleij # Reviewed-and-tested-by: Takashi Iwai # Cc: Shreeya Patel # Cc: stable@vger.kernel.org # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 # < make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- help # make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- olddefconfig # make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Assembler messages: /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:39: Error: unknown pseudo-op: `.proc' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:40: Error: unknown pseudo-op: `.callinfo' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:41: Error: unknown pseudo-op: `.entry' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:44: Error: no such instruction: `ldi 0,%r25' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:45: Error: no such instruction: `ldi 173,%r20' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:46: Error: no such instruction: `ble 0x100(%sr2,%r0)' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:49: Error: no such instruction: `ldi 1,%r25' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:50: Error: no such instruction: `ldi 173,%r20' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:51: Error: no such instruction: `ble 0x100(%sr2,%r0)' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:54: Error: unknown pseudo-op: `.exit' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:55: Error: unknown pseudo-op: `.procend' /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S:76: Error: unknown pseudo-op: `.stringz' make[2]: *** [/kisskb/src/arch/parisc/kernel/vdso32/Makefile:34: arch/parisc/kernel/vdso32/sigtramp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Assembler messages: /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:16: Error: bad or irreducible absolute expression /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:16: Error: junk at end of line, first unrecognized character is `:' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:26: Error: no such instruction: `ldw 0(%sp),%r31' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:29: Error: no such instruction: `be 0x100(%sr2,%r0)' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:30: Error: no such instruction: `ldi 0,%r20' /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S:32: Error: .cfi_endproc without corresponding .cfi_startproc make[2]: *** [/kisskb/src/arch/parisc/kernel/vdso32/Makefile:34: arch/parisc/kernel/vdso32/restart_syscall.o] Error 1 make[1]: *** [/kisskb/src/arch/parisc/Makefile:177: vdso_prepare] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 120 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_parisc-allmodconfig_parisc-gcc8 # Build took: 0:00:09.844972