# git rev-parse -q --verify 94971b64cc4ea9040c3b4b846fd664f56adfed38^{commit} 94971b64cc4ea9040c3b4b846fd664f56adfed38 already have revision, skipping fetch # git checkout -q -f -B kisskb 94971b64cc4ea9040c3b4b846fd664f56adfed38 # git clean -qxdf # < git log -1 # commit 94971b64cc4ea9040c3b4b846fd664f56adfed38 # Author: Guilherme G. Piccoli # Date: Wed Apr 27 19:49:02 2022 -0300 # # powerpc/setup: Refactor/untangle panic notifiers # # The panic notifiers infrastructure is a bit limited in the scope of # the callbacks - basically every kind of functionality is dropped # in a list that runs in the same point during the kernel panic path. # This is not really on par with the complexities and particularities # of architecture / hypervisors' needs, and a refactor is ongoing. # # As part of this refactor, it was observed that powerpc has 2 notifiers, # with mixed goals: one is just a KASLR offset dumper, whereas the other # aims to hard-disable IRQs (necessary on panic path), warn firmware of # the panic event (fadump) and run low-level platform-specific machinery # that might stop kernel execution and never come back. # # Clearly, the 2nd notifier has opposed goals: disable IRQs / fadump # should run earlier while low-level platform actions should # run late since it might not even return. Hence, this patch decouples # the notifiers splitting them in three: # # - First one is responsible for hard-disable IRQs and fadump, # should run early; # # - The kernel KASLR offset dumper is really an informative notifier, # harmless and may run at any moment in the panic path; # # - The last notifier should run last, since it aims to perform # low-level actions for specific platforms, and might never return. # It is also only registered for 2 platforms, pseries and ps3. # # The patch better documents the notifiers and clears the code too, # also removing a useless header. # # Currently no functionality change should be observed, but after # the planned panic refactor we should expect more panic reliability # with this patch. # # Signed-off-by: Guilherme G. Piccoli # Reviewed-by: Hari Bathini # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20220427224924.592546-9-gpiccoli@igalia.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 94971b64cc4ea9040c3b4b846fd664f56adfed38 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc86xx_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:135.22-137.4: Warning (pci_bridge): /pcie@f1008000: missing ranges for PCI bridge (or not a bridge) also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:92.7-117.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:102.9-116.4: Warning (pci_bridge): /pcie@f1008000/pcie@0: missing ranges for PCI bridge (or not a bridge) /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:139.22-141.4: Warning (pci_bridge): /pcie@f1009000: missing ranges for PCI bridge (or not a bridge) also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:119.7-144.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:129.9-143.4: Warning (pci_bridge): /pcie@f1009000/pcie@0: missing ranges for PCI bridge (or not a bridge) arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (unit_address_format): Failed prerequisite 'pci_bridge' arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (pci_device_reg): Failed prerequisite 'pci_bridge' arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:30.11-32.6: Warning (i2c_bus_reg): /soc@f1000000/i2c@3000/rtc@68: missing or empty reg property Completed OK # rm -rf /kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 # Build took: 0:01:09.097114