# git rev-parse -q --verify 94971b64cc4ea9040c3b4b846fd664f56adfed38^{commit} 94971b64cc4ea9040c3b4b846fd664f56adfed38 already have revision, skipping fetch # git checkout -q -f -B kisskb 94971b64cc4ea9040c3b4b846fd664f56adfed38 # git clean -qxdf # < git log -1 # commit 94971b64cc4ea9040c3b4b846fd664f56adfed38 # Author: Guilherme G. Piccoli # Date: Wed Apr 27 19:49:02 2022 -0300 # # powerpc/setup: Refactor/untangle panic notifiers # # The panic notifiers infrastructure is a bit limited in the scope of # the callbacks - basically every kind of functionality is dropped # in a list that runs in the same point during the kernel panic path. # This is not really on par with the complexities and particularities # of architecture / hypervisors' needs, and a refactor is ongoing. # # As part of this refactor, it was observed that powerpc has 2 notifiers, # with mixed goals: one is just a KASLR offset dumper, whereas the other # aims to hard-disable IRQs (necessary on panic path), warn firmware of # the panic event (fadump) and run low-level platform-specific machinery # that might stop kernel execution and never come back. # # Clearly, the 2nd notifier has opposed goals: disable IRQs / fadump # should run earlier while low-level platform actions should # run late since it might not even return. Hence, this patch decouples # the notifiers splitting them in three: # # - First one is responsible for hard-disable IRQs and fadump, # should run early; # # - The kernel KASLR offset dumper is really an informative notifier, # harmless and may run at any moment in the panic path; # # - The last notifier should run last, since it aims to perform # low-level actions for specific platforms, and might never return. # It is also only registered for 2 platforms, pseries and ps3. # # The patch better documents the notifiers and clears the code too, # also removing a useless header. # # Currently no functionality change should be observed, but after # the planned panic refactor we should expect more panic reliability # with this patch. # # Signed-off-by: Guilherme G. Piccoli # Reviewed-by: Hari Bathini # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20220427224924.592546-9-gpiccoli@igalia.com # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 94971b64cc4ea9040c3b4b846fd664f56adfed38 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig+ppc64le_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=n # Added to kconfig CONFIG_CPU_LITTLE_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_BOOK3E_64=n # Added to kconfig CONFIG_PPC_BOOK3S_64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig+ppc64le_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig+ppc64le_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:5937:warning: override: reassigning to symbol PPC64 .config:5940:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:5942:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig+ppc64le_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/mm/damon/vaddr.c:762: /kisskb/src/mm/damon/vaddr-test.h: In function 'damon_test_three_regions_in_vmas': /kisskb/src/mm/damon/vaddr-test.h:96:1: error: the frame size of 1200 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] 96 | } | ^ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:288: mm/damon/vaddr.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:550: mm/damon] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1834: mm] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig+ppc64le_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig+ppc64le_powerpc-gcc11 # Build took: 0:01:18.271834