# git rev-parse -q --verify d1dc87763f406d4e67caf16dbe438a5647692395^{commit} d1dc87763f406d4e67caf16dbe438a5647692395 already have revision, skipping fetch # git checkout -q -f -B kisskb d1dc87763f406d4e67caf16dbe438a5647692395 # git clean -qxdf # < git log -1 # commit d1dc87763f406d4e67caf16dbe438a5647692395 # Author: Stephen Brennan # Date: Thu May 19 09:50:30 2022 +0100 # # assoc_array: Fix BUG_ON during garbage collect # # A rare BUG_ON triggered in assoc_array_gc: # # [3430308.818153] kernel BUG at lib/assoc_array.c:1609! # # Which corresponded to the statement currently at line 1593 upstream: # # BUG_ON(assoc_array_ptr_is_meta(p)); # # Using the data from the core dump, I was able to generate a userspace # reproducer[1] and determine the cause of the bug. # # [1]: https://github.com/brenns10/kernel_stuff/tree/master/assoc_array_gc # # After running the iterator on the entire branch, an internal tree node # looked like the following: # # NODE (nr_leaves_on_branch: 3) # SLOT [0] NODE (2 leaves) # SLOT [1] NODE (1 leaf) # SLOT [2..f] NODE (empty) # # In the userspace reproducer, the pr_devel output when compressing this # node was: # # -- compress node 0x5607cc089380 -- # free=0, leaves=0 # [0] retain node 2/1 [nx 0] # [1] fold node 1/1 [nx 0] # [2] fold node 0/1 [nx 2] # [3] fold node 0/2 [nx 2] # [4] fold node 0/3 [nx 2] # [5] fold node 0/4 [nx 2] # [6] fold node 0/5 [nx 2] # [7] fold node 0/6 [nx 2] # [8] fold node 0/7 [nx 2] # [9] fold node 0/8 [nx 2] # [10] fold node 0/9 [nx 2] # [11] fold node 0/10 [nx 2] # [12] fold node 0/11 [nx 2] # [13] fold node 0/12 [nx 2] # [14] fold node 0/13 [nx 2] # [15] fold node 0/14 [nx 2] # after: 3 # # At slot 0, an internal node with 2 leaves could not be folded into the # node, because there was only one available slot (slot 0). Thus, the # internal node was retained. At slot 1, the node had one leaf, and was # able to be folded in successfully. The remaining nodes had no leaves, # and so were removed. By the end of the compression stage, there were 14 # free slots, and only 3 leaf nodes. The tree was ascended and then its # parent node was compressed. When this node was seen, it could not be # folded, due to the internal node it contained. # # The invariant for compression in this function is: whenever # nr_leaves_on_branch < ASSOC_ARRAY_FAN_OUT, the node should contain all # leaf nodes. The compression step currently cannot guarantee this, given # the corner case shown above. # # To fix this issue, retry compression whenever we have retained a node, # and yet nr_leaves_on_branch < ASSOC_ARRAY_FAN_OUT. This second # compression will then allow the node in slot 1 to be folded in, # satisfying the invariant. Below is the output of the reproducer once the # fix is applied: # # -- compress node 0x560e9c562380 -- # free=0, leaves=0 # [0] retain node 2/1 [nx 0] # [1] fold node 1/1 [nx 0] # [2] fold node 0/1 [nx 2] # [3] fold node 0/2 [nx 2] # [4] fold node 0/3 [nx 2] # [5] fold node 0/4 [nx 2] # [6] fold node 0/5 [nx 2] # [7] fold node 0/6 [nx 2] # [8] fold node 0/7 [nx 2] # [9] fold node 0/8 [nx 2] # [10] fold node 0/9 [nx 2] # [11] fold node 0/10 [nx 2] # [12] fold node 0/11 [nx 2] # [13] fold node 0/12 [nx 2] # [14] fold node 0/13 [nx 2] # [15] fold node 0/14 [nx 2] # internal nodes remain despite enough space, retrying # -- compress node 0x560e9c562380 -- # free=14, leaves=1 # [0] fold node 2/15 [nx 0] # after: 3 # # Changes # ======= # DH: # - Use false instead of 0. # - Reorder the inserted lines in a couple of places to put retained before # next_slot. # # ver #2) # - Fix typo in pr_devel, correct comparison to "<=" # # Fixes: 3cb989501c26 ("Add a generic associative array implementation.") # Cc: # Signed-off-by: Stephen Brennan # Signed-off-by: David Howells # cc: Andrew Morton # cc: keyrings@vger.kernel.org # Link: https://lore.kernel.org/r/20220511225517.407935-1-stephen.s.brennan@oracle.com/ # v1 # Link: https://lore.kernel.org/r/20220512215045.489140-1-stephen.s.brennan@oracle.com/ # v2 # Reviewed-by: Jarkko Sakkinen # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 d1dc87763f406d4e67caf16dbe438a5647692395 # < make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- allmodconfig # < make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- help # make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- olddefconfig # make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:24, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/stackleak_plugin.c:30: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:41, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/stackleak_plugin.c:30: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:24, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/structleak_plugin.c:32: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:41, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/structleak_plugin.c:32: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:24, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/latent_entropy_plugin.c:78: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:41, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/latent_entropy_plugin.c:78: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:24, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/randomize_layout_plugin.c:19: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/tm.h:41, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/randomize_layout_plugin.c:19: /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/../lib/gcc/aarch64-linux/5.5.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ cc1plus: warning: unrecognized command line option '-Wno-format-diag' cc1plus: warning: unrecognized command line option '-Wno-format-diag' cc1plus: warning: unrecognized command line option '-Wno-format-diag' cc1plus: warning: unrecognized command line option '-Wno-format-diag' /kisskb/src/drivers/gpu/drm/r128/r128_cce.c: In function 'r128_do_init_cce': /kisskb/src/drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM: ^ /kisskb/src/drivers/gpu/drm/r128/r128_cce.c:418:2: error: case label does not reduce to an integer constant case R128_PM4_64PIO_64VCPIO_64INDPIO: ^ make[5]: *** [/kisskb/src/scripts/Makefile.build:271: drivers/gpu/drm/r128/r128_cce.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/gpu/drm/r128] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/gpu/drm] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/gpu] Error 2 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/drivers/scsi/ufs/ufshcd.h:24:0, from /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:12: /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_40bit_rmmi': /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[15].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[16].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[28].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi_lane0': /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[8].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[9].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[19].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi': /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/drivers/scsi/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/scsi/ufs/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ make[4]: *** [/kisskb/src/scripts/Makefile.build:271: drivers/scsi/ufs/tc-dwc-g210.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/scsi/ufs] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/scsi] Error 2 make[1]: *** [/kisskb/src/Makefile:1839: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_arm64-allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_arm64-allmodconfig_arm64-gcc5 # Build took: 0:06:27.064661