Buildresult: linus/x86_64-defconfig/x86_64-gcc8 built on Jun 10 2022, 08:49

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jun 10 2022, 08:49
Duration:	0:03:19.740036
Builder:	blade4b
Revision:	netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context (`874c8ca1e60b2c564a48f7e7acc40d328d5c8733)`
Target:	linus/x86_64-defconfig/x86_64-gcc8
Branch:	linus
Compiler:	x86_64-gcc8 (x86_64-linux-gcc (GCC) 8.5.0 / GNU ld (GNU Binutils) 2.36.1)
Config:	defconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 874c8ca1e60b2c564a48f7e7acc40d328d5c8733^{commit} 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 already have revision, skipping fetch # git checkout -q -f -B kisskb 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 # git clean -qxdf # < git log -1 # commit 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 # Author: David Howells <dhowells@redhat.com> # Date: Thu Jun 9 21:46:04 2022 +0100 # # netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context # # While randstruct was satisfied with using an open-coded "void " offset # cast for the netfs_i_context <-> inode casting, __builtin_object_size() as # used by FORTIFY_SOURCE was not as easily fooled. This was causing the # following complaint[1] from gcc v12: # # In file included from include/linux/string.h:253, # from include/linux/ceph/ceph_debug.h:7, # from fs/ceph/inode.c:2: # In function 'fortify_memset_chk', # inlined from 'netfs_i_context_init' at include/linux/netfs.h:326:2, # inlined from 'ceph_alloc_inode' at fs/ceph/inode.c:463:2: # include/linux/fortify-string.h:242:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning] # 242 \| __write_overflow_field(p_size_field, size); # \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # # Fix this by embedding a struct inode into struct netfs_i_context (which # should perhaps be renamed to struct netfs_inode). The struct inode # vfs_inode fields are then removed from the 9p, afs, ceph and cifs inode # structs and vfs_inode is then simply changed to "netfs.inode" in those # filesystems. # # Further, rename netfs_i_context to netfs_inode, get rid of the # netfs_inode() function that converted a netfs_i_context pointer to an # inode pointer (that can now be done with &ctx->inode) and rename the # netfs_i_context() function to netfs_inode() (which is now a wrapper # around container_of()). # # Most of the changes were done with: # # perl -p -i -e 's/vfs_inode/netfs.inode/'g \ # `git grep -l 'vfs_inode' -- fs/{9p,afs,ceph,cifs}/.[ch]` # # Kees suggested doing it with a pair structure[2] and a special # declarator to insert that into the network filesystem's inode # wrapper[3], but I think it's cleaner to embed it - and then it doesn't # matter if struct randomisation reorders things. # # Dave Chinner suggested using a filesystem-specific VFS_I() function in # each filesystem to convert that filesystem's own inode wrapper struct # into the VFS inode struct[4]. # # Version #2: # - Fix a couple of missed name changes due to a disabled cifs option. # - Rename nfs_i_context to nfs_inode # - Use "netfs" instead of "nic" as the member name in per-fs inode wrapper # structs. # # [ This also undoes commit 507160f46c55 ("netfs: gcc-12: temporarily # disable '-Wattribute-warning' for now") that is no longer needed ] # # Fixes: bc899ee1c898 ("netfs: Add a netfs inode context") # Reported-by: Jeff Layton <jlayton@kernel.org> # Signed-off-by: David Howells <dhowells@redhat.com> # Reviewed-by: Jeff Layton <jlayton@kernel.org> # Reviewed-by: Kees Cook <keescook@chromium.org> # Reviewed-by: Xiubo Li <xiubli@redhat.com> # cc: Jonathan Corbet <corbet@lwn.net> # cc: Eric Van Hensbergen <ericvh@gmail.com> # cc: Latchesar Ionkov <lucho@ionkov.net> # cc: Dominique Martinet <asmadeus@codewreck.org> # cc: Christian Schoenebeck <linux_oss@crudebyte.com> # cc: Marc Dionne <marc.dionne@auristor.com> # cc: Ilya Dryomov <idryomov@gmail.com> # cc: Steve French <smfrench@gmail.com> # cc: William Kucharski <william.kucharski@oracle.com> # cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> # cc: Dave Chinner <david@fromorbit.com> # cc: linux-doc@vger.kernel.org # cc: v9fs-developer@lists.sourceforge.net # cc: linux-afs@lists.infradead.org # cc: ceph-devel@vger.kernel.org # cc: linux-cifs@vger.kernel.org # cc: samba-technical@lists.samba.org # cc: linux-fsdevel@vger.kernel.org # cc: linux-hardening@vger.kernel.org # Link: https://lore.kernel.org/r/d2ad3a3d7bdd794c6efb562d2f2b655fb67756b9.camel@kernel.org/ [1] # Link: https://lore.kernel.org/r/20220517210230.864239-1-keescook@chromium.org/ [2] # Link: https://lore.kernel.org/r/20220518202212.2322058-1-keescook@chromium.org/ [3] # Link: https://lore.kernel.org/r/20220524101205.GI2306852@dread.disaster.area/ [4] # Link: https://lore.kernel.org/r/165296786831.3591209.12111293034669289733.stgit@warthog.procyon.org.uk/ # v1 # Link: https://lore.kernel.org/r/165305805651.4094995.7763502506786714216.stgit@warthog.procyon.org.uk # v2 # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 # < make -s -j 24 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- x86_64_defconfig # < make -s -j 24 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 24 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 24 ARCH=x86 O=/kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/linus_x86_64_defconfig_x86_64-gcc8 # Build took: 0:03:19.740036

© Michael Ellerman 2006-2018.