# git rev-parse -q --verify 874c8ca1e60b2c564a48f7e7acc40d328d5c8733^{commit} 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 already have revision, skipping fetch # git checkout -q -f -B kisskb 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 # git clean -qxdf # < git log -1 # commit 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 # Author: David Howells # Date: Thu Jun 9 21:46:04 2022 +0100 # # netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context # # While randstruct was satisfied with using an open-coded "void *" offset # cast for the netfs_i_context <-> inode casting, __builtin_object_size() as # used by FORTIFY_SOURCE was not as easily fooled. This was causing the # following complaint[1] from gcc v12: # # In file included from include/linux/string.h:253, # from include/linux/ceph/ceph_debug.h:7, # from fs/ceph/inode.c:2: # In function 'fortify_memset_chk', # inlined from 'netfs_i_context_init' at include/linux/netfs.h:326:2, # inlined from 'ceph_alloc_inode' at fs/ceph/inode.c:463:2: # include/linux/fortify-string.h:242:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning] # 242 | __write_overflow_field(p_size_field, size); # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # # Fix this by embedding a struct inode into struct netfs_i_context (which # should perhaps be renamed to struct netfs_inode). The struct inode # vfs_inode fields are then removed from the 9p, afs, ceph and cifs inode # structs and vfs_inode is then simply changed to "netfs.inode" in those # filesystems. # # Further, rename netfs_i_context to netfs_inode, get rid of the # netfs_inode() function that converted a netfs_i_context pointer to an # inode pointer (that can now be done with &ctx->inode) and rename the # netfs_i_context() function to netfs_inode() (which is now a wrapper # around container_of()). # # Most of the changes were done with: # # perl -p -i -e 's/vfs_inode/netfs.inode/'g \ # `git grep -l 'vfs_inode' -- fs/{9p,afs,ceph,cifs}/*.[ch]` # # Kees suggested doing it with a pair structure[2] and a special # declarator to insert that into the network filesystem's inode # wrapper[3], but I think it's cleaner to embed it - and then it doesn't # matter if struct randomisation reorders things. # # Dave Chinner suggested using a filesystem-specific VFS_I() function in # each filesystem to convert that filesystem's own inode wrapper struct # into the VFS inode struct[4]. # # Version #2: # - Fix a couple of missed name changes due to a disabled cifs option. # - Rename nfs_i_context to nfs_inode # - Use "netfs" instead of "nic" as the member name in per-fs inode wrapper # structs. # # [ This also undoes commit 507160f46c55 ("netfs: gcc-12: temporarily # disable '-Wattribute-warning' for now") that is no longer needed ] # # Fixes: bc899ee1c898 ("netfs: Add a netfs inode context") # Reported-by: Jeff Layton # Signed-off-by: David Howells # Reviewed-by: Jeff Layton # Reviewed-by: Kees Cook # Reviewed-by: Xiubo Li # cc: Jonathan Corbet # cc: Eric Van Hensbergen # cc: Latchesar Ionkov # cc: Dominique Martinet # cc: Christian Schoenebeck # cc: Marc Dionne # cc: Ilya Dryomov # cc: Steve French # cc: William Kucharski # cc: "Matthew Wilcox (Oracle)" # cc: Dave Chinner # cc: linux-doc@vger.kernel.org # cc: v9fs-developer@lists.sourceforge.net # cc: linux-afs@lists.infradead.org # cc: ceph-devel@vger.kernel.org # cc: linux-cifs@vger.kernel.org # cc: samba-technical@lists.samba.org # cc: linux-fsdevel@vger.kernel.org # cc: linux-hardening@vger.kernel.org # Link: https://lore.kernel.org/r/d2ad3a3d7bdd794c6efb562d2f2b655fb67756b9.camel@kernel.org/ [1] # Link: https://lore.kernel.org/r/20220517210230.864239-1-keescook@chromium.org/ [2] # Link: https://lore.kernel.org/r/20220518202212.2322058-1-keescook@chromium.org/ [3] # Link: https://lore.kernel.org/r/20220524101205.GI2306852@dread.disaster.area/ [4] # Link: https://lore.kernel.org/r/165296786831.3591209.12111293034669289733.stgit@warthog.procyon.org.uk/ # v1 # Link: https://lore.kernel.org/r/165305805651.4094995.7763502506786714216.stgit@warthog.procyon.org.uk # v2 # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version # < git log --format=%s --max-count=1 874c8ca1e60b2c564a48f7e7acc40d328d5c8733 # < make -s -j 40 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- allmodconfig # Added to kconfig CONFIG_64BIT=n # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MODULE_SIG=n # < make -s -j 40 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- help # make -s -j 40 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- olddefconfig # make -s -j 40 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- :1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] WARNING: modpost: EXPORT symbol "empty_zero_page" [vmlinux] version generation failed, symbol will not be versioned. Is "empty_zero_page" prototyped in ? WARNING: modpost: EXPORT symbol "__udelay" [vmlinux] version generation failed, symbol will not be versioned. Is "__udelay" prototyped in ? WARNING: modpost: EXPORT symbol "__ndelay" [vmlinux] version generation failed, symbol will not be versioned. Is "__ndelay" prototyped in ? WARNING: modpost: EXPORT symbol "__ashldi3" [vmlinux] version generation failed, symbol will not be versioned. Is "__ashldi3" prototyped in ? WARNING: modpost: EXPORT symbol "__ashrdi3" [vmlinux] version generation failed, symbol will not be versioned. Is "__ashrdi3" prototyped in ? WARNING: modpost: EXPORT symbol "bzero_1page" [vmlinux] version generation failed, symbol will not be versioned. Is "bzero_1page" prototyped in ? WARNING: modpost: EXPORT symbol "__copy_1page" [vmlinux] version generation failed, symbol will not be versioned. Is "__copy_1page" prototyped in ? WARNING: modpost: EXPORT symbol "__divdi3" [vmlinux] version generation failed, symbol will not be versioned. Is "__divdi3" prototyped in ? WARNING: modpost: EXPORT symbol "___rw_read_enter" [vmlinux] version generation failed, symbol will not be versioned. Is "___rw_read_enter" prototyped in ? WARNING: modpost: EXPORT symbol "___rw_read_exit" [vmlinux] version generation failed, symbol will not be versioned. Is "___rw_read_exit" prototyped in ? WARNING: modpost: EXPORT symbol "___rw_read_try" [vmlinux] version generation failed, symbol will not be versioned. Is "___rw_read_try" prototyped in ? WARNING: modpost: EXPORT symbol "___rw_write_enter" [vmlinux] version generation failed, symbol will not be versioned. Is "___rw_write_enter" prototyped in ? WARNING: modpost: EXPORT symbol "__lshrdi3" [vmlinux] version generation failed, symbol will not be versioned. Is "__lshrdi3" prototyped in ? WARNING: modpost: EXPORT symbol "__muldi3" [vmlinux] version generation failed, symbol will not be versioned. Is "__muldi3" prototyped in ? arch/sparc/kernel/head_32.o: In function `current_pc': (.head.text+0x5040): relocation truncated to fit: R_SPARC_WDISP22 against `.init.text' arch/sparc/kernel/head_32.o: In function `halt_notsup': (.head.text+0x5100): relocation truncated to fit: R_SPARC_WDISP22 against `.init.text' arch/sparc/kernel/head_32.o: In function `leon_init': (.init.text+0xa4): relocation truncated to fit: R_SPARC_WDISP22 against symbol `leon_smp_cpu_startup' defined in .text section in arch/sparc/kernel/trampoline_32.o arch/sparc/kernel/process_32.o:(.fixup+0x4): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/process_32.o:(.fixup+0xc): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/signal_32.o:(.fixup+0x4): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/signal_32.o:(.fixup+0x10): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/signal_32.o:(.fixup+0x1c): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/signal_32.o:(.fixup+0x28): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/signal_32.o:(.fixup+0x34): relocation truncated to fit: R_SPARC_WDISP22 against `.text' arch/sparc/kernel/signal_32.o:(.fixup+0x40): additional relocation overflows omitted from the output make[1]: *** [/kisskb/src/Makefile:1164: vmlinux] Error 1 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 40 ARCH=sparc O=/kisskb/build/linus_sparc-allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_sparc-allmodconfig_sparc64-gcc5 # Build took: 0:05:20.903004