# git rev-parse -q --verify 7f62ad1aedf6048a3d0354a9838415f97bb5ec14^{commit} 7f62ad1aedf6048a3d0354a9838415f97bb5ec14 already have revision, skipping fetch # git checkout -q -f -B kisskb 7f62ad1aedf6048a3d0354a9838415f97bb5ec14 # git clean -qxdf # < git log -1 # commit 7f62ad1aedf6048a3d0354a9838415f97bb5ec14 # Author: Gustavo A. R. Silva # Date: Wed Apr 6 19:36:51 2022 -0500 # # treewide: uapi: Replace zero-length arrays with flexible-array members # # There is a regular need in the kernel to provide a way to declare # having a dynamically sized set of trailing elements in a structure. # Kernel code should always use “flexible array members”[1] for these # cases. The older style of one-element or zero-length arrays should # no longer be used[2]. # # This code was transformed with the help of Coccinelle: # (linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch) # # @@ # identifier S, member, array; # type T1, T2; # @@ # # struct S { # ... # T1 member; # T2 array[ # - 0 # ]; # }; # # -fstrict-flex-arrays=3 is coming and we need to land these changes # to prevent issues like these in the short future: # # ../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0, # but the source string has length 2 (including NUL byte) [-Wfortify-source] # strcpy(de3->name, "."); # ^ # # Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If # this breaks anything, we can use a union with a new member name. # # [1] https://en.wikipedia.org/wiki/Flexible_array_member # [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays # # Link: https://github.com/KSPP/linux/issues/78 # Build-tested-by: kernel test robot # Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/ # Acked-by: Dan Williams # For ndctl.h # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 7f62ad1aedf6048a3d0354a9838415f97bb5ec14 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/build_bug.h:5, from /kisskb/src/include/linux/container_of.h:5, from /kisskb/src/include/linux/list.h:5, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:13: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) Completed OK # rm -rf /kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc11 # Build took: 0:02:54.877802