# git rev-parse -q --verify 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381^{commit} 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381 already have revision, skipping fetch # git checkout -q -f -B kisskb 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381 # git clean -qxdf # < git log -1 # commit 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381 # Author: Gustavo A. R. Silva # Date: Wed Apr 6 19:36:51 2022 -0500 # # treewide: uapi: Replace zero-length arrays with flexible-array members # # There is a regular need in the kernel to provide a way to declare # having a dynamically sized set of trailing elements in a structure. # Kernel code should always use “flexible array members”[1] for these # cases. The older style of one-element or zero-length arrays should # no longer be used[2]. # # This code was transformed with the help of Coccinelle: # (linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch) # # @@ # identifier S, member, array; # type T1, T2; # @@ # # struct S { # ... # T1 member; # T2 array[ # - 0 # ]; # }; # # -fstrict-flex-arrays=3 is coming and we need to land these changes # to prevent issues like these in the short future: # # ../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0, # but the source string has length 2 (including NUL byte) [-Wfortify-source] # strcpy(de3->name, "."); # ^ # # Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If # this breaks anything, we can use a union with a new member name. # # [1] https://en.wikipedia.org/wiki/Flexible_array_member # [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays # # Link: https://github.com/KSPP/linux/issues/78 # Build-tested-by: kernel test robot # Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/ # Acked-by: Dan Williams # For ndctl.h # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381 # < make -s -j 32 ARCH=x86 O=/kisskb/build/gustavoars_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 32 ARCH=x86 O=/kisskb/build/gustavoars_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 32 ARCH=x86 O=/kisskb/build/gustavoars_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 32 ARCH=x86 O=/kisskb/build/gustavoars_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/gustavoars_x86-allmodconfig_x86_64-gcc8 # Build took: 0:18:51.333699