# git rev-parse -q --verify af3e9579ecfbe1796334bb25a2f0a6437983673a^{commit} # git fetch -q -n -f git://fs.ozlabs.ibm.com/kernel/linus master # git rev-parse -q --verify af3e9579ecfbe1796334bb25a2f0a6437983673a^{commit} af3e9579ecfbe1796334bb25a2f0a6437983673a # git checkout -q -f -B kisskb af3e9579ecfbe1796334bb25a2f0a6437983673a # git clean -qxdf # < git log -1 # commit af3e9579ecfbe1796334bb25a2f0a6437983673a # Author: Linus Torvalds # Date: Sat Aug 6 13:24:56 2022 -0700 # # Revert "iommu/dma: Add config for PCI SAC address trick" # # This reverts commit 4bf7fda4dce22214c70c49960b1b6438e6260b67. # # It turns out that it was hopelessly naive to think that this would work, # considering that we've always done this. The first machine I actually # tested this on broke at bootup, getting to # # Reached target cryptsetup.target - Local Encrypted Volumes. # # and then hanging. It's unclear what actually fails, since there's a lot # else going on around that time (eg amdgpu probing also happens around # that same time, but it could be some other random init thing that didn't # complete earlier and just caused the boot to hang at that point). # # The expectations that we should default to some unsafe and untested mode # seems entirely unfounded, and the belief that this wouldn't affect # modern systems is clearly entirely false. The machine in question is # about two years old, so it's not exactly shiny, but it's also not some # dusty old museum piece PDP-11 in a closet. # # Cc: Robin Murphy # Cc: Christoph Hellwig # Cc: John Garry # Cc: Joerg Roedel # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 af3e9579ecfbe1796334bb25a2f0a6437983673a # < make -s -j 32 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- randconfig # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # < make -s -j 32 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- help # make -s -j 32 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- olddefconfig .config:6132:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 32 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- In file included from :0:0: In function 'kvm_vm_ioctl_set_device_addr.isra.50', inlined from 'kvm_arch_vm_ioctl' at /kisskb/src/arch/arm64/kvm/arm.c:1454:10: /kisskb/src/include/linux/compiler_types.h:354:38: error: call to '__compiletime_assert_563' declared with attribute error: FIELD_GET: mask is not constant _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:335:4: note: in definition of macro '__compiletime_assert' prefix ## suffix(); \ ^ /kisskb/src/include/linux/compiler_types.h:354:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ /kisskb/src/include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^ /kisskb/src/include/linux/bitfield.h:65:3: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask), \ ^ /kisskb/src/include/linux/bitfield.h:128:3: note: in expansion of macro '__BF_FIELD_CHECK' __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET: "); \ ^ /kisskb/src/arch/arm64/kvm/arm.c:1423:10: note: in expansion of macro 'FIELD_GET' switch (FIELD_GET(KVM_ARM_DEVICE_ID_MASK, dev_addr->id)) { ^ make[3]: *** [/kisskb/src/scripts/Makefile.build:249: arch/arm64/kvm/arm.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:466: arch/arm64/kvm] Error 2 make[1]: *** [/kisskb/src/Makefile:1844: arch/arm64] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 32 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5 # Build took: 0:03:04.202688