# git rev-parse -q --verify af3e9579ecfbe1796334bb25a2f0a6437983673a^{commit} af3e9579ecfbe1796334bb25a2f0a6437983673a already have revision, skipping fetch # git checkout -q -f -B kisskb af3e9579ecfbe1796334bb25a2f0a6437983673a # git clean -qxdf # < git log -1 # commit af3e9579ecfbe1796334bb25a2f0a6437983673a # Author: Linus Torvalds # Date: Sat Aug 6 13:24:56 2022 -0700 # # Revert "iommu/dma: Add config for PCI SAC address trick" # # This reverts commit 4bf7fda4dce22214c70c49960b1b6438e6260b67. # # It turns out that it was hopelessly naive to think that this would work, # considering that we've always done this. The first machine I actually # tested this on broke at bootup, getting to # # Reached target cryptsetup.target - Local Encrypted Volumes. # # and then hanging. It's unclear what actually fails, since there's a lot # else going on around that time (eg amdgpu probing also happens around # that same time, but it could be some other random init thing that didn't # complete earlier and just caused the boot to hang at that point). # # The expectations that we should default to some unsafe and untested mode # seems entirely unfounded, and the belief that this wouldn't affect # modern systems is clearly entirely false. The machine in question is # about two years old, so it's not exactly shiny, but it's also not some # dusty old museum piece PDP-11 in a closet. # # Cc: Robin Murphy # Cc: Christoph Hellwig # Cc: John Garry # Cc: Joerg Roedel # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 af3e9579ecfbe1796334bb25a2f0a6437983673a # < make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c: In function 'UseMinimumDCFCLK': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:6806:1: error: the frame size of 2096 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] } ^ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:249: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.o] Error 1 make[5]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3778:1: error: the frame size of 2160 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] } // ModeSupportAndSystemConfigurationFull ^ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:249: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/gpu/drm/amd/amdgpu] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/gpu/drm] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/gpu] Error 2 make[1]: *** [/kisskb/src/Makefile:1844: drivers] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 32 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 # Build took: 0:17:34.731969