# git rev-parse -q --verify af3e9579ecfbe1796334bb25a2f0a6437983673a^{commit} af3e9579ecfbe1796334bb25a2f0a6437983673a already have revision, skipping fetch # git checkout -q -f -B kisskb af3e9579ecfbe1796334bb25a2f0a6437983673a # git clean -qxdf # < git log -1 # commit af3e9579ecfbe1796334bb25a2f0a6437983673a # Author: Linus Torvalds # Date: Sat Aug 6 13:24:56 2022 -0700 # # Revert "iommu/dma: Add config for PCI SAC address trick" # # This reverts commit 4bf7fda4dce22214c70c49960b1b6438e6260b67. # # It turns out that it was hopelessly naive to think that this would work, # considering that we've always done this. The first machine I actually # tested this on broke at bootup, getting to # # Reached target cryptsetup.target - Local Encrypted Volumes. # # and then hanging. It's unclear what actually fails, since there's a lot # else going on around that time (eg amdgpu probing also happens around # that same time, but it could be some other random init thing that didn't # complete earlier and just caused the boot to hang at that point). # # The expectations that we should default to some unsafe and untested mode # seems entirely unfounded, and the belief that this wouldn't affect # modern systems is clearly entirely false. The machine in question is # about two years old, so it's not exactly shiny, but it's also not some # dusty old museum piece PDP-11 in a closet. # # Cc: Robin Murphy # Cc: Christoph Hellwig # Cc: John Garry # Cc: Joerg Roedel # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 af3e9579ecfbe1796334bb25a2f0a6437983673a # < make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MIPS_CPS_NS16550_BASE=0x1b0003f8 # Added to kconfig CONFIG_MIPS_CPS_NS16550_SHIFT=0 # < make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux- help # make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux- olddefconfig .config:14005:warning: override: reassigning to symbol MIPS_CPS_NS16550_SHIFT # make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg): /pci@14000000/pci2_root@0,0,0: PCI unit address format error, expected "0,0" In file included from /kisskb/src/include/linux/string.h:253, from /kisskb/src/include/linux/bitmap.h:11, from /kisskb/src/include/linux/cpumask.h:12, from /kisskb/src/arch/mips/include/asm/processor.h:15, from /kisskb/src/arch/mips/include/asm/thread_info.h:16, from /kisskb/src/include/linux/thread_info.h:60, from /kisskb/src/include/asm-generic/current.h:5, from ./arch/mips/include/generated/asm/current.h:1, from /kisskb/src/include/linux/sched.h:12, from /kisskb/src/include/linux/ratelimit.h:6, from /kisskb/src/include/linux/dev_printk.h:16, from /kisskb/src/include/linux/device.h:15, from /kisskb/src/drivers/hwmon/lm90.c:99: In function '__fortify_strlen', inlined from 'strlcpy' at /kisskb/src/include/linux/fortify-string.h:159:10, inlined from 'lm90_detect' at /kisskb/src/drivers/hwmon/lm90.c:2550:2: /kisskb/src/include/linux/fortify-string.h:50:33: error: '__builtin_strlen' reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread] 50 | #define __underlying_strlen __builtin_strlen | ^ /kisskb/src/include/linux/fortify-string.h:141:24: note: in expansion of macro '__underlying_strlen' 141 | return __underlying_strlen(p); | ^~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:249: drivers/hwmon/lm90.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/hwmon] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1844: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/mips-linux/bin/mips-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_mips-allmodconfig_mips-gcc11 # Build took: 0:07:35.453676