# git rev-parse -q --verify 426b4ca2d6a5ab51f6b6175d06e4f8ddea434cdf^{commit} 426b4ca2d6a5ab51f6b6175d06e4f8ddea434cdf already have revision, skipping fetch # git checkout -q -f -B kisskb 426b4ca2d6a5ab51f6b6175d06e4f8ddea434cdf # git clean -qxdf # < git log -1 # commit 426b4ca2d6a5ab51f6b6175d06e4f8ddea434cdf # Merge: b8dcef877ab5 5fadbd992996 # Author: Linus Torvalds # Date: Tue Aug 9 09:52:28 2022 -0700 # # Merge tag 'fs.setgid.v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux # # Pull setgid updates from Christian Brauner: # "This contains the work to move setgid stripping out of individual # filesystems and into the VFS itself. # # Creating files that have both the S_IXGRP and S_ISGID bit raised in # directories that themselves have the S_ISGID bit set requires # additional privileges to avoid security issues. # # When a filesystem creates a new inode it needs to take care that the # caller is either in the group of the newly created inode or they have # CAP_FSETID in their current user namespace and are privileged over the # parent directory of the new inode. If any of these two conditions is # true then the S_ISGID bit can be raised for an S_IXGRP file and if not # it needs to be stripped. # # However, there are several key issues with the current implementation: # # - S_ISGID stripping logic is entangled with umask stripping. # # For example, if the umask removes the S_IXGRP bit from the file # about to be created then the S_ISGID bit will be kept. # # The inode_init_owner() helper is responsible for S_ISGID stripping # and is called before posix_acl_create(). So we can end up with two # different orderings: # # 1. FS without POSIX ACL support # # First strip umask then strip S_ISGID in inode_init_owner(). # # In other words, if a filesystem doesn't support or enable POSIX # ACLs then umask stripping is done directly in the vfs before # calling into the filesystem: # # 2. FS with POSIX ACL support # # First strip S_ISGID in inode_init_owner() then strip umask in # posix_acl_create(). # # In other words, if the filesystem does support POSIX ACLs then # unmask stripping may be done in the filesystem itself when # calling posix_acl_create(). # # Note that technically filesystems are free to impose their own # ordering between posix_acl_create() and inode_init_owner() meaning # that there's additional ordering issues that influence S_ISGID # inheritance. # # (Note that the commit message of commit 1639a49ccdce ("fs: move # S_ISGID stripping into the vfs_*() helpers") gets the ordering # between inode_init_owner() and posix_acl_create() the wrong way # around. I realized this too late.) # # - Filesystems that don't rely on inode_init_owner() don't get S_ISGID # stripping logic. # # While that may be intentional (e.g. network filesystems might just # defer setgid stripping to a server) it is often just a security # issue. # # Note that mandating the use of inode_init_owner() was proposed as # an alternative solution but that wouldn't fix the ordering issues # and there are examples such as afs where the use of # inode_init_owner() isn't possible. # # In any case, we should also try the cleaner and generalized # solution first before resorting to this approach. # # - We still have S_ISGID inheritance bugs years after the initial # round of S_ISGID inheritance fixes: # # e014f37db1a2 ("xfs: use setattr_copy to set vfs inode attributes") # 01ea173e103e ("xfs: fix up non-directory creation in SGID directories") # fd84bfdddd16 ("ceph: fix up non-directory creation in SGID directories") # # All of this led us to conclude that the current state is too messy. # While we won't be able to make it completely clean as # posix_acl_create() is still a filesystem specific call we can improve # the S_SIGD stripping situation quite a bit by hoisting it out of # inode_init_owner() and into the respective vfs creation operations. # # The obvious advantage is that we don't need to rely on individual # filesystems getting S_ISGID stripping right and instead can # standardize the ordering between S_ISGID and umask stripping directly # in the VFS. # # A few short implementation notes: # # - The stripping logic needs to happen in vfs_*() helpers for the sake # of stacking filesystems such as overlayfs that rely on these # helpers taking care of S_ISGID stripping. # # - Security hooks have never seen the mode as it is ultimately seen by # the filesystem because of the ordering issue we mentioned. Nothing # is changed for them. We simply continue to strip the umask before # passing the mode down to the security hooks. # # - The following filesystems use inode_init_owner() and thus relied on # S_ISGID stripping: spufs, 9p, bfs, btrfs, ext2, ext4, f2fs, # hfsplus, hugetlbfs, jfs, minix, nilfs2, ntfs3, ocfs2, omfs, # overlayfs, ramfs, reiserfs, sysv, ubifs, udf, ufs, xfs, zonefs, # bpf, tmpfs. # # We've audited all callchains as best as we could. More details can # be found in the commit message to 1639a49ccdce ("fs: move S_ISGID # stripping into the vfs_*() helpers")" # # * tag 'fs.setgid.v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux: # ceph: rely on vfs for setgid stripping # fs: move S_ISGID stripping into the vfs_*() helpers # fs: Add missing umask strip in vfs_tmpfile # fs: add mode_strip_sgid() helper # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-ld --version # < git log --format=%s --max-count=1 426b4ca2d6a5ab51f6b6175d06e4f8ddea434cdf # < make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MIPS_CPS_NS16550_BASE=0x1b0003f8 # Added to kconfig CONFIG_MIPS_CPS_NS16550_SHIFT=0 # Added to kconfig # < make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- help # make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- olddefconfig .config:14011:warning: override: reassigning to symbol MIPS_CPS_NS16550_SHIFT # make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- /kisskb/src/arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg): /pci@14000000/pci2_root@0,0,0: PCI unit address format error, expected "0,0" In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:35, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/latent_entropy_plugin.c:78: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:41, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/latent_entropy_plugin.c:78: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/mips/mips.h:2913:20: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf (STREAM, "\t.space\t"HOST_WIDE_INT_PRINT_UNSIGNED"\n", (SIZE)) ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:56, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/latent_entropy_plugin.c:78: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:35, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/structleak_plugin.c:32: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:41, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/structleak_plugin.c:32: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/mips/mips.h:2913:20: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf (STREAM, "\t.space\t"HOST_WIDE_INT_PRINT_UNSIGNED"\n", (SIZE)) ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:56, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/structleak_plugin.c:32: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:35, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/sancov_plugin.c:22: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:41, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/sancov_plugin.c:22: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/mips/mips.h:2913:20: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf (STREAM, "\t.space\t"HOST_WIDE_INT_PRINT_UNSIGNED"\n", (SIZE)) ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:56, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/sancov_plugin.c:22: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:35, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/randomize_layout_plugin.c:19: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/elfos.h:170:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:41, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/randomize_layout_plugin.c:19: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/config/mips/mips.h:2913:20: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf (STREAM, "\t.space\t"HOST_WIDE_INT_PRINT_UNSIGNED"\n", (SIZE)) ^ In file included from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/tm.h:56, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/gcc-plugin.h:31, from /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/plugin.h:23, from /kisskb/src/scripts/gcc-plugins/gcc-common.h:9, from /kisskb/src/scripts/gcc-plugins/randomize_layout_plugin.c:19: /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/5.4.0/plugin/include/defaults.h:126:24: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ cc1plus: warning: unrecognized command line option '-Wno-format-diag' cc1plus: warning: unrecognized command line option '-Wno-format-diag' cc1plus: warning: unrecognized command line option '-Wno-format-diag' cc1plus: warning: unrecognized command line option '-Wno-format-diag' In file included from /kisskb/src/arch/mips/include/asm/mips-cps.h:10:0, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:113, from /kisskb/src/include/linux/lockdep.h:14, from /kisskb/src/include/linux/spinlock.h:62, from /kisskb/src/include/linux/mmzone.h:8, from /kisskb/src/include/linux/gfp.h:7, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/net/mac80211/tx.c:14: In function 'u32_encode_bits', inlined from 'ieee80211_mlo_multicast_tx' at /kisskb/src/net/mac80211/tx.c:4351:17, inlined from 'ieee80211_subif_start_xmit' at /kisskb/src/net/mac80211/tx.c:4394:3: /kisskb/src/include/linux/bitfield.h:151:3: error: call to '__field_overflow' declared with attribute error: value doesn't fit into mask __field_overflow(); \ ^ /kisskb/src/include/linux/bitfield.h:171:2: note: in expansion of macro '____MAKE_OP' ____MAKE_OP(u##size,u##size,,) ^ /kisskb/src/include/linux/bitfield.h:174:1: note: in expansion of macro '__MAKE_OP' __MAKE_OP(32) ^ make[3]: *** [/kisskb/src/scripts/Makefile.build:249: net/mac80211/tx.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:466: net/mac80211] Error 2 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:32:0: /kisskb/src/drivers/media/platform/nxp/imx-pxp.c: In function 'pxp_setup_csc': /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:334:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:334:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:351:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:351:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:368:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_rec709_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:368:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:385:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_rec709_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:385:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:402:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt2020_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:402:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:419:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt2020_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:419:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:436:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_smpte240m_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:436:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:453:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_smpte240m_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:453:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ make[5]: *** [/kisskb/src/scripts/Makefile.build:249: drivers/media/platform/nxp/imx-pxp.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/media/platform/nxp] Error 2 make[4]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/ufs/ufshcd.h:24:0, from /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:12: /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_40bit_rmmi': /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[15].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[16].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[28].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi_lane0': /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[8].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[9].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[19].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi': /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:245:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:247:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ make[4]: *** [/kisskb/src/scripts/Makefile.build:249: drivers/ufs/host/tc-dwc-g210.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/ufs/host] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/ufs] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1844: net] Error 2 make[1]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/media/platform] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:466: drivers/media] Error 2 make[1]: *** [/kisskb/src/Makefile:1844: drivers] Error 2 make: *** [Makefile:219: __sub-make] Error 2 Command 'make -s -j 120 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_mips-allmodconfig_mipsel-gcc5 # Build took: 0:05:50.206350