# git rev-parse -q --verify 21f9c8a13bb2a0c24d9c6b86bc0896542a28c197^{commit} 21f9c8a13bb2a0c24d9c6b86bc0896542a28c197 already have revision, skipping fetch # git checkout -q -f -B kisskb 21f9c8a13bb2a0c24d9c6b86bc0896542a28c197 # git clean -qxdf # < git log -1 # commit 21f9c8a13bb2a0c24d9c6b86bc0896542a28c197 # Author: Linus Torvalds # Date: Thu Aug 11 08:40:01 2022 -0700 # # Revert "Makefile.extrawarn: re-enable -Wformat for clang" # # This reverts commit 258fafcd0683d9ccfa524129d489948ab3ddc24c. # # The clang -Wformat warning is terminally broken, and the clang people # can't seem to get their act together. # # This test program causes a warning with clang: # # #include # # int main(int argc, char **argv) # { # printf("%hhu\n", 'a'); # } # # resulting in # # t.c:5:19: warning: format specifies type 'unsigned char' but the argument has type 'int' [-Wformat] # printf("%hhu\n", 'a'); # ~~~~ ^~~ # %d # # and apparently clang people consider that a feature, because they don't # want to face the reality of how either C character constants, C # arithmetic, and C varargs functions work. # # The rest of the world just shakes their head at that kind of # incompetence, and turns off -Wformat for clang again. # # And no, the "you should use a pointless cast to shut this up" is not a # valid answer. That warning should not exist in the first place, or at # least be optinal with some "-Wformat-me-harder" kind of option. # # [ Admittedly, there's also very little reason to *ever* use '%hh[ud]' in # C, but what little reason there is is entirely about 'I want to see # only the low 8 bits of the argument'. So I would suggest nobody ever # use that format in the first place, but if they do, the clang # behavious is simply always wrong. Because '%hhu' takes an 'int'. It's # that simple. ] # # Reported-by: Sudip Mukherjee (Codethink) # Cc: Nick Desaulniers # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-9.4.0-nolibc/or1k-linux/bin/or1k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.4.0-nolibc/or1k-linux/bin/or1k-linux-ld --version # < git log --format=%s --max-count=1 21f9c8a13bb2a0c24d9c6b86bc0896542a28c197 # < make -s -j 48 ARCH=openrisc O=/kisskb/build/linus_or1ksim_defconfig_or32-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.4.0-nolibc/or1k-linux/bin/or1k-linux- or1ksim_defconfig # < make -s -j 48 ARCH=openrisc O=/kisskb/build/linus_or1ksim_defconfig_or32-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.4.0-nolibc/or1k-linux/bin/or1k-linux- help # make -s -j 48 ARCH=openrisc O=/kisskb/build/linus_or1ksim_defconfig_or32-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.4.0-nolibc/or1k-linux/bin/or1k-linux- olddefconfig # make -s -j 48 ARCH=openrisc O=/kisskb/build/linus_or1ksim_defconfig_or32-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.4.0-nolibc/or1k-linux/bin/or1k-linux- Completed OK # rm -rf /kisskb/build/linus_or1ksim_defconfig_or32-gcc9 # Build took: 0:00:37.471153