# git rev-parse -q --verify 573ae4f13f630d6660008f1974c0a8a29c30e18a^{commit} 573ae4f13f630d6660008f1974c0a8a29c30e18a already have revision, skipping fetch # git checkout -q -f -B kisskb 573ae4f13f630d6660008f1974c0a8a29c30e18a # git clean -qxdf # < git log -1 # commit 573ae4f13f630d6660008f1974c0a8a29c30e18a # Author: Jens Wiklander # Date: Thu Aug 18 13:08:59 2022 +0200 # # tee: add overflow check in register_shm_helper() # # With special lengths supplied by user space, register_shm_helper() has # an integer overflow when calculating the number of pages covered by a # supplied user space memory region. # # This causes internal_get_user_pages_fast() a helper function of # pin_user_pages_fast() to do a NULL pointer dereference: # # Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010 # Modules linked in: # CPU: 1 PID: 173 Comm: optee_example_a Not tainted 5.19.0 #11 # Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015 # pc : internal_get_user_pages_fast+0x474/0xa80 # Call trace: # internal_get_user_pages_fast+0x474/0xa80 # pin_user_pages_fast+0x24/0x4c # register_shm_helper+0x194/0x330 # tee_shm_register_user_buf+0x78/0x120 # tee_ioctl+0xd0/0x11a0 # __arm64_sys_ioctl+0xa8/0xec # invoke_syscall+0x48/0x114 # # Fix this by adding an an explicit call to access_ok() in # tee_shm_register_user_buf() to catch an invalid user space address # early. # # Fixes: 033ddf12bcf5 ("tee: add register user memory") # Cc: stable@vger.kernel.org # Reported-by: Nimish Mishra # Reported-by: Anirban Chakraborty # Reported-by: Debdeep Mukhopadhyay # Suggested-by: Jerome Forissier # Signed-off-by: Jens Wiklander # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 573ae4f13f630d6660008f1974c0a8a29c30e18a # < make -s -j 120 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux- randconfig WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n] Selected by [y]: - QCOM_RPMPD [=y] && PM [=y] && QCOM_SMD_RPM [=y] # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_BPF_PRELOAD=n # Added to kconfig # < make -s -j 120 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 120 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig .config:5844:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD .config:5846:warning: override: reassigning to symbol GCC_PLUGINS WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n] Selected by [y]: - QCOM_RPMPD [=y] && PM [=y] && QCOM_SMD_RPM [=y] # make -s -j 120 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux- WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n] Selected by [y]: - QCOM_RPMPD [=y] && PM [=y] && QCOM_SMD_RPM [=y] WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n] Selected by [y]: - QCOM_RPMPD [=y] && PM [=y] && QCOM_SMD_RPM [=y] WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n] Selected by [y]: - QCOM_RPMPD [=y] && PM [=y] && QCOM_SMD_RPM [=y] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3778:1: error: the frame size of 2112 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] 3778 | } // ModeSupportAndSystemConfigurationFull | ^ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:249: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:465: drivers/gpu/drm/amd/amdgpu] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:465: drivers/gpu/drm] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:465: drivers/gpu] Error 2 make[1]: *** [/kisskb/src/Makefile:1855: drivers] Error 2 make: *** [Makefile:222: __sub-make] Error 2 Command 'make -s -j 120 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/x86_64-linux/bin/x86_64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc11 # Build took: 0:02:03.137631