# git rev-parse -q --verify 6cf07810e9ef8535d60160d13bf0fd05f2af38e7^{commit} 6cf07810e9ef8535d60160d13bf0fd05f2af38e7 already have revision, skipping fetch # git checkout -q -f -B kisskb 6cf07810e9ef8535d60160d13bf0fd05f2af38e7 # git clean -qxdf # < git log -1 # commit 6cf07810e9ef8535d60160d13bf0fd05f2af38e7 # Author: Nathan Chancellor # Date: Tue Aug 30 08:12:56 2022 -0700 # # powerpc/papr_scm: Ensure rc is always initialized in papr_scm_pmu_register() # # Clang warns: # # arch/powerpc/platforms/pseries/papr_scm.c:492:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] # if (!p->stat_buffer_len) # ^~~~~~~~~~~~~~~~~~~ # arch/powerpc/platforms/pseries/papr_scm.c:523:64: note: uninitialized use occurs here # dev_info(&p->pdev->dev, "nvdimm pmu didn't register rc=%d\n", rc); # ^~ # include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info' # dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) # ^~~~~~~~~~~ # include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' # _p_func(dev, fmt, ##__VA_ARGS__); \ # ^~~~~~~~~~~ # arch/powerpc/platforms/pseries/papr_scm.c:492:2: note: remove the 'if' if its condition is always false # if (!p->stat_buffer_len) # ^~~~~~~~~~~~~~~~~~~~~~~~ # arch/powerpc/platforms/pseries/papr_scm.c:484:8: note: initialize the variable 'rc' to silence this warning # int rc, nodeid; # ^ # = 0 # 1 warning generated. # # The call to papr_scm_pmu_check_events() was eliminated but a return code # was not added to the if statement. Add the same return code from # papr_scm_pmu_check_events() for this condition so there is no more # warning. # # Fixes: 9b1ac04698a4 ("powerpc/papr_scm: Fix nvdimm event mappings") # Signed-off-by: Nathan Chancellor # Signed-off-by: Michael Ellerman # Link: https://github.com/ClangBuiltLinux/linux/issues/1701 # Link: https://lore.kernel.org/r/20220830151256.1473169-1-nathan@kernel.org # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 6cf07810e9ef8535d60160d13bf0fd05f2af38e7 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- pmac32_defconfig # Added to kconfig CONFIG_SMP=y # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4364:warning: override: reassigning to symbol SMP # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/powerpc-fixes_pmac32_defconfig+SMP_powerpc-gcc5 # Build took: 0:02:15.694983