# git rev-parse -q --verify a970174d7a1010cb29a5b0c9fa0626abdefcfcbe^{commit} a970174d7a1010cb29a5b0c9fa0626abdefcfcbe already have revision, skipping fetch # git checkout -q -f -B kisskb a970174d7a1010cb29a5b0c9fa0626abdefcfcbe # git clean -qxdf # < git log -1 # commit a970174d7a1010cb29a5b0c9fa0626abdefcfcbe # Author: Steven Rostedt (Google) # Date: Mon Oct 24 11:45:36 2022 -0400 # # x86/mm: Do not verify W^X at boot up # # Adding on the kernel command line "ftrace=function" triggered: # # CPA detected W^X violation: 8000000000000063 -> 0000000000000063 range: 0xffffffffc0013000 - 0xffffffffc0013fff PFN 10031b # WARNING: CPU: 0 PID: 0 at arch/x86/mm/pat/set_memory.c:609 # verify_rwx+0x61/0x6d # Call Trace: # __change_page_attr_set_clr+0x146/0x8a6 # change_page_attr_set_clr+0x135/0x268 # change_page_attr_clear.constprop.0+0x16/0x1c # set_memory_x+0x2c/0x32 # arch_ftrace_update_trampoline+0x218/0x2db # ftrace_update_trampoline+0x16/0xa1 # __register_ftrace_function+0x93/0xb2 # ftrace_startup+0x21/0xf0 # register_ftrace_function_nolock+0x26/0x40 # register_ftrace_function+0x4e/0x143 # function_trace_init+0x7d/0xc3 # tracer_init+0x23/0x2c # tracing_set_tracer+0x1d5/0x206 # register_tracer+0x1c0/0x1e4 # init_function_trace+0x90/0x96 # early_trace_init+0x25c/0x352 # start_kernel+0x424/0x6e4 # x86_64_start_reservations+0x24/0x2a # x86_64_start_kernel+0x8c/0x95 # secondary_startup_64_no_verify+0xe0/0xeb # # This is because at boot up, kernel text is writable, and there's no # reason to do tricks to updated it. But the verifier does not # distinguish updates at boot up and at run time, and causes a warning at # time of boot. # # Add a check for system_state == SYSTEM_BOOTING and allow it if that is # the case. # # [ These SYSTEM_BOOTING special cases are all pretty horrid, but the x86 # text_poke() code does some odd things at bootup, forcing this for now # - Linus ] # # Link: https://lore.kernel.org/r/20221024112730.180916b3@gandalf.local.home # Fixes: 652c5bf380ad0 ("x86/mm: Refuse W^X violations") # Signed-off-by: Steven Rostedt (Google) # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 a970174d7a1010cb29a5b0c9fa0626abdefcfcbe # < make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/m68k-linux/bin/m68k-linux- sun3_defconfig # < make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/m68k-linux/bin/m68k-linux- In file included from /kisskb/src/include/linux/string.h:20, from /kisskb/src/include/linux/bitmap.h:11, from /kisskb/src/include/linux/cpumask.h:12, from /kisskb/src/include/linux/mm_types_task.h:14, from /kisskb/src/include/linux/mm_types.h:5, from /kisskb/src/include/linux/buildid.h:5, from /kisskb/src/include/linux/module.h:14, from /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:32: In function 'check586', inlined from 'sun3_82586_probe1' at /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:365:6, inlined from 'sun3_82586_probe' at /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:311:8: /kisskb/src/arch/m68k/include/asm/string.h:68:25: warning: '__builtin_memset' offset [0, 11] is out of the bounds [0, 0] [-Warray-bounds] 68 | #define memset(d, c, n) __builtin_memset(d, c, n) | ^~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:218:9: note: in expansion of macro 'memset' 218 | memset((char *)p->scp,0, sizeof(struct scp_struct)); | ^~~~~~ In file included from /kisskb/src/include/linux/swab.h:5, from /kisskb/src/include/uapi/linux/byteorder/big_endian.h:14, from /kisskb/src/include/linux/byteorder/big_endian.h:5, from /kisskb/src/arch/m68k/include/uapi/asm/byteorder.h:5, from /kisskb/src/include/asm-generic/bitops/le.h:6, from /kisskb/src/arch/m68k/include/asm/bitops.h:545, from /kisskb/src/include/linux/bitops.h:68, from /kisskb/src/include/linux/kernel.h:22, from /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:31: /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:989:122: warning: array subscript 1 is above array bounds of 'volatile struct transmit_cmd_struct *[1]' [-Warray-bounds] 989 | printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); | ~~~~~~~~~~~~^~~ /kisskb/src/include/uapi/linux/swab.h:107:19: note: in definition of macro '__swab16' 107 | __fswab16(x)) | ^ /kisskb/src/include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap' 457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:989:17: note: in expansion of macro 'printk' 989 | printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); | ^~~~~~ /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:155:46: note: while referencing 'xmit_cmds' 155 | volatile struct transmit_cmd_struct *xmit_cmds[NUM_XMIT_BUFFS]; | ^~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_sun3_defconfig_m68k-gcc11 # Build took: 0:03:15.343805